Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(StudentDataService, AnnotationService, TeacherDataService): simplify state retrieval logic using Array.findLast() #2008

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

hirokiterashima
Copy link
Member

Changes

This pull request includes various changes to improve the efficiency and readability of the code in the studentDataService and teacherDataService files. The main changes involve replacing loops with the findLast method and removing unnecessary dependencies and methods.

Codebase simplification and efficiency improvements:

Test cleanup:

Test

  • VLE and CM work as before, especially code that handles loading component states

…simplify state retrieval logic using Array.findLast()
@hirokiterashima hirokiterashima added this to the Tech Debt 17 -> 16 milestone Nov 26, 2024
@hirokiterashima hirokiterashima self-assigned this Nov 26, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review November 26, 2024 20:26
@hirokiterashima hirokiterashima merged commit 5a27618 into develop Nov 27, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-use-array-findLast branch November 27, 2024 18:30
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.163.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant