refactor(StudentDataService, AnnotationService, TeacherDataService): simplify state retrieval logic using Array.findLast() #2008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes various changes to improve the efficiency and readability of the code in the
studentDataService
andteacherDataService
files. The main changes involve replacing loops with thefindLast
method and removing unnecessary dependencies and methods.Codebase simplification and efficiency improvements:
src/assets/wise5/services/annotationService.ts
: Simplified thegetLatestAnnotation
method by replacing the loop with thefindLast
method.src/assets/wise5/services/studentDataService.ts
: Simplified thegetLatestComponentStateByNodeIdAndComponentId
,getLatestSubmitComponentState
, andgetLatestNodeEnteredEventNodeIdWithExistingNode
methods by replacing loops with thefindLast
method. [1] [2]src/assets/wise5/services/teacherDataService.ts
: Simplified thegetLatestComponentStateByWorkgroupIdNodeIdAndComponentId
andgetLatestComponentStateByWorkgroupIdNodeId
methods by replacing loops with thefindLast
method. [1] [2]Test cleanup:
src/app/services/studentDataService.spec.ts
: Removed theMatDialogModule
import and$rootScope
variable, and cleaned up related test cases by removing unnecessary$broadcast
spy and expectations. [1] [2] [3] [4]Test