refactor(TeacherDataService): Move getVisiblePeriodsById() to PeerGroupDialog

[hirokiterashima]

Changes

This pull request includes several changes to improve the encapsulation and code quality of the PeerGroupDialogComponent and TeacherDataService classes. The most important changes include modifying access levels for class members, refactoring methods for better readability, and removing redundant code.

Encapsulation improvements in PeerGroupDialogComponent:

• Changed the access levels of currentPeriodChangedSubscription, peerGroupingName, and periods from public to private or protected.
• Updated the constructor to use dataService and projectService instead of teacherDataService and teacherProjectService.

Refactoring methods in PeerGroupDialogComponent:

• Moved the unsubscribe call to the ngOnDestroy lifecycle hook and refactored the setPeriods method for better readability.

Removal of redundant code in TeacherDataService:

• Removed the getVisiblePeriodsById and getPeriodById methods as they were no longer needed. [1] [2]

Test

• Peer Grouping dialog appears and you can change the period as before

[hirokiterashima]

🎉 This issue has been resolved in version 5.163.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀