refactor(MCStudent): remove modules #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
src/assets/wise5/componentsdirectory, primarily focused on renaming and refactoring theMultipleChoiceStudentcomponent and its related modules. The changes aim to improve code clarity and maintainability.Component and module renaming:
MultipleChoiceStudenttoMultipleChoiceStudentComponentinComponents.tsand updated the corresponding import statements and component references. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Type improvements:
getChoiceTypemethod inMultipleChoiceComponentto a union type'radio' | 'checkbox'for better type safety.Code cleanup:
MultipleChoiceStudentModuleand its associated import statements, as it is no longer needed after the refactor.These changes help improve the readability and maintainability of the code by clarifying component names and ensuring consistent use of types.
Test