refactor(TeacherDataService, DiscussionService, TeacherDiscussionService): simplify component state retrieval

[hirokiterashima]

Changes

This pull request includes several changes to the DiscussionService, TeacherDiscussionService, and related components and services to simplify and improve the codebase. The most important changes include the removal of unused methods, updates to method signatures, and improvements to code readability.

Codebase simplification:

• src/app/services/discussionService.spec.ts: Removed unnecessary method implementations in MockTeacherDataService and simplified the test structure for getClassmateResponses. [1] [2] [3]
• src/app/services/teacherDiscussionService.spec.ts: Removed unused service imports and updated the MockTeacherDataService method signature. [1] [2]
• src/assets/wise5/components/discussion/discussion-show-work/discussion-show-work.component.ts: Changed setStudentWork method to private and improved line breaks for readability. [1] [2] [3]

Method and constructor updates:

• src/assets/wise5/components/discussion/discussionService.ts: Updated the constructor to use consistent parameter ordering and renamed ConfigService to configService for consistency. [1] [2]
• src/assets/wise5/components/discussion/teacherDiscussionService.ts: Added a new private method getComponentStates to simplify fetching component states and updated method calls accordingly. [1] [2]

Removal of unused methods:

• src/assets/wise5/services/teacherDataService.ts: Removed unused methods getComponentStatesByComponentIds and getComponentStatesByWorkgroupIdAndComponentIds. [1] [2]

Test

• Discussion posts appear as before in CM

[hirokiterashima]

🎉 This issue has been resolved in version 5.163.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀