Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(StudentProgressComponent): Convert to standalone #2021

Merged

Conversation

hirokiterashima
Copy link
Member

Changes

This pull request includes significant updates to the StudentProgressComponent in the classroom monitor module. The changes focus on refactoring the component to use Angular's standalone components, improving encapsulation, and updating the template syntax. Additionally, the test file for the component has been simplified.

Refactoring and Encapsulation:

Template Syntax Improvements:

Test File Simplification:

Module Import Changes:

Test

  • Grade by team's team selection page works as before, especially sorting by fields and anonymizing student names

@hirokiterashima hirokiterashima added this to the Standalone Components milestone Dec 17, 2024
@hirokiterashima hirokiterashima self-assigned this Dec 17, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review December 17, 2024 04:21
@hirokiterashima hirokiterashima merged commit 346b33a into develop Dec 17, 2024
3 of 5 checks passed
@hirokiterashima hirokiterashima deleted the convert-StudentProgressComponent-to-standalone branch December 17, 2024 04:40
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.164.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant