Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-authoring): Move add component button position #2029

Merged
merged 4 commits into from
Dec 20, 2024
Merged

feat(node-authoring): Move add component button position #2029

merged 4 commits into from
Dec 20, 2024

Conversation

breity
Copy link
Member

@breity breity commented Dec 20, 2024

Changes

  • Move add component buttons to in between each component
  • Add divider with animation on hover
  • Only scroll component into view if necessary

Test

  • Adding and moving components both work properly

@breity breity added the enhancement New feature of any size or improvement (UI, performance, security) label Dec 20, 2024
@breity breity self-assigned this Dec 20, 2024
hirokiterashima
hirokiterashima approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breity breity merged commit 9600ee2 into develop Dec 20, 2024
5 checks passed
@breity breity deleted the node-authoring-move-add-component-button-position branch December 20, 2024 20:11
@hirokiterashima
Copy link
Member

🎉 This issue has been resolved in version 5.164.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@breity breity

Labels
enhancement New feature of any size or improvement (UI, performance, security) released
Projects
No open projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breity @hirokiterashima