Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat light attenuation #230

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions adf_loader/version_1_0/adf_loader_1_0.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1162,6 +1162,7 @@ bool ADFLoader_1_0::loadLightAttribs(YAML::Node *a_node, afLightAttributes *attr
YAML::Node spotExponentNode = node["spot exponent"];
YAML::Node shadowQualityNode = node["shadow quality"];
YAML::Node cuttOffAngleNode = node["cutoff angle"];
YAML::Node attenuationNode = node["attenuation"];

bool valid = true;

Expand Down Expand Up @@ -1214,6 +1215,13 @@ bool ADFLoader_1_0::loadLightAttribs(YAML::Node *a_node, afLightAttributes *attr
attribs->m_cuttoffAngle = cuttOffAngleNode.as<double>();
}

if (attenuationNode.IsDefined()){
attribs->m_attenuationDefined = true;
if (attenuationNode["constant"].IsDefined()) attribs->m_constantAttenuation = attenuationNode["constant"].as<double>();
if (attenuationNode["linear"].IsDefined()) attribs->m_linearAttenuation = attenuationNode["linear"].as<double>();
if (attenuationNode["quadratic"].IsDefined()) attribs->m_quadraticAttenuation = attenuationNode["quadratic"].as<double>();
}

return valid;
}

Expand Down
8 changes: 8 additions & 0 deletions ambf_framework/afAttributes.h
Original file line number Diff line number Diff line change
Expand Up @@ -623,10 +623,18 @@ struct afLightAttributes: public afBaseObjectAttributes
afLightAttributes(){
m_spotExponent = 0.7;
m_cuttoffAngle = 0.7;
m_constantAttenuation = 1.0;
m_linearAttenuation = 0.0;
m_quadraticAttenuation = 0.0;
m_attenuationDefined = false;
}

double m_spotExponent;
double m_cuttoffAngle;
double m_constantAttenuation;
double m_linearAttenuation;
double m_quadraticAttenuation;
bool m_attenuationDefined;
afVector3d m_direction;

afShadowQualityType m_shadowQuality;
Expand Down
8 changes: 7 additions & 1 deletion ambf_framework/afFramework.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7216,6 +7216,12 @@ bool afLight::createFromAttribs(afLightAttributes *a_attribs)
m_spotLight->setCutOffAngleDeg(a_attribs->m_cuttoffAngle * (180/3.14));
m_spotLight->setShadowMapEnabled(true);

if (a_attribs->m_attenuationDefined){
setConstantAttenuation(a_attribs->m_constantAttenuation);
setLinearAttenuation(a_attribs->m_linearAttenuation);
setQuadraticAttenuation(a_attribs->m_quadraticAttenuation);
}

switch (a_attribs->m_shadowQuality) {
case afShadowQualityType::NO_SHADOW:
m_spotLight->setShadowMapEnabled(false);
Expand Down Expand Up @@ -8302,7 +8308,7 @@ bool afVolume::createFromAttribs(afVolumeAttributes *a_attribs)
m_voxelObject = new cVoxelObject();
// Setting transparency before setting the texture ensures that the rendering does not show empty spaces as black
// and the depth point cloud is able to see the volume
m_voxelObject->setTransparencyLevel(1.0);
// m_voxelObject->setTransparencyLevel(1.0);

cTexture3dPtr texture = cTexture3d::create();
texture->setImage(m_multiImage);
Expand Down
12 changes: 12 additions & 0 deletions ambf_framework/afFramework.h
Original file line number Diff line number Diff line change
Expand Up @@ -2083,6 +2083,18 @@ class afLight: public afBaseObject{

cGenericLight* getInternalLight();

double getConstantAttenuation(){return m_spotLight->getAttConstant();}

double getLinearAttenuation(){return m_spotLight->getAttLinear();}

double getQuadraticAttenuation(){return m_spotLight->getAttQuadratic();}

void setConstantAttenuation(double att){m_spotLight->setAttConstant(att);}

void setLinearAttenuation(double att){m_spotLight->setAttLinear(att);}

void setQuadraticAttenuation(double att){m_spotLight->setAttQuadratic(att);}

protected:
cSpotLight* m_spotLight;

Expand Down
7 changes: 7 additions & 0 deletions ambf_plugins/core/ros_comm_plugin/ObjectCommPlugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,10 @@ void afObjectCommunicationPlugin::lightFetchCommand(afLightPtr lightPtr, double
lightPtr->setCutOffAngle(cutoff_angle);

lightPtr->resolveParent(parent_name);

lightPtr->setConstantAttenuation(m_lightCommPtr->get_constant_attenuation());
lightPtr->setLinearAttenuation(m_lightCommPtr->get_linear_attenuation());
lightPtr->setQuadraticAttenuation(m_lightCommPtr->get_quadratic_attenuation());
}

m_read_count = 0;
Expand All @@ -544,6 +548,9 @@ void afObjectCommunicationPlugin::lightUpdateState(afLightPtr lightPtr, double d
m_lightCommPtr->set_cuttoff_angle(lightPtr->getCutOffAngle());
m_lightCommPtr->set_type(ambf_comm::LightType::SPOT);
m_lightCommPtr->set_parent_name(lightPtr->m_parentName);
m_lightCommPtr->set_attenuation(lightPtr->getConstantAttenuation(),
lightPtr->getLinearAttenuation(),
lightPtr->getQuadraticAttenuation());

m_lightCommPtr->set_params_on_server();
m_paramsSet = true;
Expand Down
8 changes: 7 additions & 1 deletion ambf_ros_modules/ambf_server/include/ambf_server/Light.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ enum class LightType{
enum class LightParamsEnum{
cuttoff_angle,
parent_name,
type
type,
attenuation
};


Expand All @@ -76,10 +77,14 @@ class LightParams{
// Setters
void set_type(LightType val){m_light_type = val;}
void set_cuttoff_angle(double val){m_cuttoff_angle = val;}
void set_attenuation(double cons, double lin, double quad);

// Getters
LightType get_type(){return m_light_type;}
double get_cuttoff_angle(){return m_cuttoff_angle;}
double get_constant_attenuation(){return m_attenuation["constant"];}
double get_linear_attenuation(){return m_attenuation["linear"];}
double get_quadratic_attenuation(){return m_attenuation["quadratic"];}

// This a flag to check if any param has been updated
bool m_paramsChanged;
Expand All @@ -92,6 +97,7 @@ class LightParams{
// Datatyped Variables for params defined on the server
double m_type;
double m_cuttoff_angle;
std::map<std::string, double> m_attenuation; // Constant, Linear and Quadratic Attenuation
LightType m_light_type;
};

Expand Down
27 changes: 27 additions & 0 deletions ambf_ros_modules/ambf_server/src/Light.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,28 +56,42 @@ const std::string light_param_enum_to_str(LightParamsEnum enumVal)
if (enumVal == LightParamsEnum::cuttoff_angle) return "cutoff_angle";
else if (enumVal == LightParamsEnum::parent_name) return "parent_name";
else if (enumVal == LightParamsEnum::type) return "type";
else if (enumVal == LightParamsEnum::attenuation) return "attenuation";
return "";
}

LightParams::LightParams(){
m_paramsChanged = false;
m_attenuation["constant"] = 1.0;
m_attenuation["linear"] = 0.0;
m_attenuation["quadratic"] = 0.0;
}

void LightParams::set_attenuation(double cons, double lin, double quad)
{
m_attenuation["constant"] = cons;
m_attenuation["linear"] = lin;
m_attenuation["quadratic"] = quad;
}

void Light::set_params_on_server(){
nodePtr->setParam(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::cuttoff_angle), m_cuttoff_angle);
nodePtr->setParam(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::parent_name), m_State.parent_name.data);
nodePtr->setParam(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::type), light_type_enum_to_str(m_light_type));
nodePtr->setParam(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::attenuation), m_attenuation);
}

void Light::update_params_from_server(){
double ca;
std::string pn;
std::string lt;
std::map<std::string, double> att;
LightType lt_enum;

nodePtr->getParamCached(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::cuttoff_angle), ca);
nodePtr->getParamCached(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::parent_name), pn);
nodePtr->getParamCached(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::type), lt);
nodePtr->getParamCached(m_base_prefix + "/" + light_param_enum_to_str(LightParamsEnum::attenuation), att);

if (lt.compare(light_type_enum_to_str(LightType::SPOT)) == 0){
lt_enum = LightType::SPOT;
Expand Down Expand Up @@ -106,6 +120,19 @@ void Light::update_params_from_server(){
std::cerr << "INFO! PARAMS CHANGED FOR \"" << m_name << "\"\n";
}

std::map<std::string, double>::iterator it;
for (it = m_attenuation.begin() ; it != m_attenuation.end() ; ++it){
try{
if (att[it->first] != it->second){
m_paramsChanged = true;
it->second = att[it->first];
}
}
catch (...){
// Do nothing
}
}

// Finally update the local copies of the params
m_cuttoff_angle = ca;
m_State.parent_name.data = pn;
Expand Down
5 changes: 5 additions & 0 deletions external/chai3d/src/lighting/CSpotLight.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@ void cSpotLight::renderLightSource(cRenderOptions& a_options)
// set cutoff angle
glLightf(m_glLightNumber, GL_SPOT_CUTOFF, m_cutOffAngleDeg);

// Set Attenuation Constants
glLightf(m_glLightNumber, GL_CONSTANT_ATTENUATION, getAttConstant());
glLightf(m_glLightNumber, GL_LINEAR_ATTENUATION, getAttLinear());
glLightf(m_glLightNumber, GL_QUADRATIC_ATTENUATION, getAttQuadratic());

#endif
}

Expand Down
Loading