Added ClothingLimitVision Component #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add dirty calls to mask system * among --------- Co-authored-by: deltanedas <@deltanedas:kde.org>
riddleridou
changed the title
Spatison
requested changes
Aug 24, 2024
Comment on lines
+27
to
+29
| <Folder Include="Clothing\Components\" /> | ||
| <Folder Include="Spawners\" /> | ||
| <Folder Include="_White\VisionLimit\Overlays\System\" /> |
There was a problem hiding this comment.
Suggested change
| <Folder Include="Clothing\Components\" /> | |
| <Folder Include="Spawners\" /> | |
| <Folder Include="_White\VisionLimit\Overlays\System\" /> | |
| <Folder Include="Spawners\" /> |
Это тут зачем?
| @@ -16,6 +16,7 @@ | |||
| <ProjectReference Include="..\RobustToolbox\Lidgren.Network\Lidgren.Network.csproj"> | |||
| <Private>false</Private> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\RobustToolbox\Robust.Client\Robust.Client.csproj" /> | |||
| @@ -25,6 +26,7 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <Folder Include="DeltaV\Abilities\" /> | |||
| <Folder Include="_White\VisionLimit\" /> | |||
Comment on lines
+56
to
+59
| if (_player.LocalEntity == uid) | ||
| { | ||
| _overlayMan.RemoveOverlay(_overlay); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (_player.LocalEntity == uid) | |
| { | |
| _overlayMan.RemoveOverlay(_overlay); | |
| } | |
| if (_player.LocalEntity == uid) | |
| _overlayMan.RemoveOverlay(_overlay); |
Скобочки можно убрать
Comment on lines
+10
to
+12
| - type: Mask | ||
| - type: ClothingLimitVision | ||
| radius: 6 |
There was a problem hiding this comment.
Suggested change
| - type: Mask | |
| - type: ClothingLimitVision | |
| radius: 6 | |
| - type: Mask # WD EDIT | |
| - type: ClothingLimitVision # WD EDIT | |
| radius: 6 |
There was a problem hiding this comment.
Радиус слишком большой, 3 будет лучше, тк от 3х до 6 не должно быть видно нормально, в этом радиусе должно быть размытие какое-то или затемление
|
закрыт с позором |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Добавлен компонент ClothingLimitVision и клиентский компонент VisionLimit
Надетая одежда с ClothingLimitVision ограничивает обзор космонавтика до указанного кол-ва тайлов (примерно).
ClothingLimitVision добавлен сварочной маске.
Цветной оверлей и функционал сварочной маски буду добавлять в отдельных ПР.
Медиа
Список
Изменения
🆑 vanx