Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Ru Loc / Локализация #51

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[Fix] Ru Loc / Локализация #51

merged 1 commit into from
Sep 9, 2024

Conversation

Spatison
Copy link
Member

@Spatison Spatison commented Sep 9, 2024

Описание PR

Почистит переводы в папках c z-w. Добавил немного переводов.
Переместил папку prototupes из папки ss14-ru в папку ru-RU.
Снес паку White, ибо переводы от туда нигде не используются и есть аналогичная папка _white


Изменения

🆑 Spatison

  • add: Added a few translations / Добавлено немного переводов

Copy link
Contributor

coderabbitai bot commented Sep 9, 2024

Walkthrough

The pull request introduces several modifications to the Russian localization files across various components. Key changes include the simplification of the OOC patron message format in the chat manager, restructuring and renaming of whitelist command messages for consistency, and the addition of new entries related to unknown values and confirmation prompts in the generic localization file. These updates aim to enhance clarity and usability for users interacting with the chat and command functionalities.

Changes

Files Change Summary
Resources/Locale/ru-RU/chat/managers/chat-manager.ftl Modified OOC patron message format to remove bold and reputation variable, retaining color coding.
Resources/Locale/ru-RU/connection-messages.ftl Added new entries for whitelist commands, restructured command prefixes, and included usage guidance.
Resources/Locale/ru-RU/generic.ftl Added translations for unknown values, hours, playtime, and confirmation prompts.

Tip

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 523aacb and 8a46df0.

Files selected for processing (3)
  • Resources/Locale/ru-RU/chat/managers/chat-manager.ftl (1 hunks)
  • Resources/Locale/ru-RU/connection-messages.ftl (2 hunks)
  • Resources/Locale/ru-RU/generic.ftl (1 hunks)
Files skipped from review due to trivial changes (1)
  • Resources/Locale/ru-RU/chat/managers/chat-manager.ftl
Additional comments not posted (16)
Resources/Locale/ru-RU/generic.ftl (4)

8-8: Approved: New entry for unknown title.

The translation for generic-unknown-title is appropriate and aligns with the intended use.


12-12: Approved: New entry for hours.

The translation for generic-hours is correct and fits well within the context.


14-14: Approved: New entry for playtime title.

The translation for generic-playtime-title is accurate and clearly conveys the intended meaning.


16-16: Approved: New entry for confirmation prompt.

The translation for generic-confirm is straightforward and appropriate for user interactions requiring confirmation.

Resources/Locale/ru-RU/connection-messages.ftl (12)

15-15: Approved: New description for whitelist add command.

The description for cmd-whitelistadd-desc is clear and accurately describes the command's functionality.


16-16: Approved: New help message for whitelist add command.

The help message for cmd-whitelistadd-help is concise and effectively communicates the command syntax.


17-17: Approved: New message for existing user in whitelist.

The message for cmd-whitelistadd-existing clearly informs the user that the specified username is already in the whitelist.


18-18: Approved: New confirmation message for added user to whitelist.

The confirmation message for cmd-whitelistadd-added is straightforward and provides clear feedback that the user has been added to the whitelist.


19-19: Approved: New error message for user not found in whitelist add command.

The error message for cmd-whitelistadd-not-found is clear and necessary for informing the user about the unsuccessful operation.


20-20: Approved: New argument placeholder for whitelist add command.

The argument placeholder for cmd-whitelistadd-arg-player is essential for clarity in command syntax and helps prevent user errors.


22-22: Approved: New description for whitelist remove command.

The description for cmd-whitelistremove-desc is clear and accurately describes the command's functionality.


23-23: Approved: New help message for whitelist remove command.

The help message for cmd-whitelistremove-help is concise and effectively communicates the command syntax.


24-24: Approved: New message for non-existing user in whitelist remove command.

The message for cmd-whitelistremove-existing clearly informs the user that the specified username is not in the whitelist.


25-25: Approved: New confirmation message for removed user from whitelist.

The confirmation message for cmd-whitelistremove-removed is straightforward and provides clear feedback that the user has been removed from the whitelist.


26-26: Approved: New error message for user not found in whitelist remove command.

The error message for cmd-whitelistremove-not-found is clear and necessary for informing the user about the unsuccessful operation.


27-27: Approved: New argument placeholder for whitelist remove command.

The argument placeholder for cmd-whitelistremove-arg-player is essential for clarity in command syntax and helps prevent user errors.

Copy link
Collaborator

@Remuchi Remuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I guess?

@Remuchi Remuchi merged commit 2bb7b74 into master Sep 9, 2024
10 checks passed
@Remuchi Remuchi deleted the translate-fix branch September 9, 2024 16:23
riddleridou added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants