[Port] Syndicate Implanter / Имплантер Синдиката #78
Conversation
WalkthroughThe pull request introduces new entries and modifications to localization files for both English and Russian languages, specifically for an "Implanter" item in the uplink catalog. It adds new entries for the Implanter and modifies existing entries for the "betrayal knife," which is renamed to "Experimental syndicate teleporter." Additionally, a new entity definition for "ImplanterSyndi" is introduced, along with updates to the uplink catalog and related YAML files. Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (7)
Resources/Locale/ru-RU/_white/prototypes/entities/objects/misc/implanters.ftl (1)
1-2: LGTM! Consider adding a name field for consistency.The localization entry for
ImplanterSyndilooks good. The entity is correctly defined, and the description is appropriate for a Russian localization file.For consistency with other entity definitions, consider adding a separate name field. This would allow for a distinct name to be displayed in-game, separate from the entity ID. Here's a suggested modification:
ent-ImplanterSyndi = { ent-BaseImplanter } + .name = Имплантер Синдиката .desc = Компактный одноразовый шприц, предназначенный исключительно для введения и извлечения подкожных имплантатов.This change would provide more flexibility in how the item is displayed in-game while maintaining the entity relationship.
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml (2)
12-12: Add a newline at the end of the file.To comply with YAML best practices and resolve the linter warning, please add a newline character at the end of the file.
Apply this change:
implantTime: 2 +🧰 Tools
🪛 yamllint
[error] 12-12: no new line character at the end of file
(new-line-at-end-of-file)
1-12: Consider adding more context about gameplay implications.While the entity definition is technically sound, it might be helpful to provide more context about how the ImplanterSyndi differs from the standard Implanter in terms of gameplay. Some questions to consider:
- Are there specific implants that can only be used with this syndicate version?
- How do the draw and implant times of 2 compare to the standard Implanter? Are they faster or slower?
- Are there any restrictions or special conditions for using this item in the game?
Adding comments or documentation addressing these points could help other developers and game designers understand the intended use and balance of this new entity.
🧰 Tools
🪛 yamllint
[error] 12-12: no new line character at the end of file
(new-line-at-end-of-file)
Resources/Locale/en-US/_white/store/uplink-catalog.ftl (2)
Line range hint
6-7: LGTM! Consider minor wording adjustment.The changes to the "betrayal knife" entry effectively communicate its new functionality as an experimental teleporter. This aligns well with the PR's objective of introducing syndicate-related features.
Consider adjusting the last sentence of the description for clarity:
-uplink-betrayal-knife-desc = Syndicate teleporter, when used, moves 3-8 meters forward. In case of teleportation into a wall, uses emergency teleportation. Has 4 charge. +uplink-betrayal-knife-desc = Syndicate teleporter, when used, moves 3-8 meters forward. In case of teleportation into a wall, uses emergency teleportation. Has 4 charges.This small change from "charge" to "charges" improves grammatical correctness.
13-14: LGTM! Consider minor formatting adjustment.The addition of the Implanter entries aligns perfectly with the PR's objective of porting the syndicate implanter. The name and description are clear and informative.
For consistency with other entries in the file, consider capitalizing the first letter of the description:
-uplink-implanter-desc = An advanced implant that allows you to quickly insert and remove implants. +uplink-implanter-desc = An advanced implant that allows you to quickly insert and remove implants.This small change maintains the capitalization style used in other item descriptions.
Resources/Locale/ru-RU/_white/store/uplink-catalog.ftl (1)
13-14: LGTM! Consider a minor wording improvement.The new entries for the Implanter are well-formatted and consistent with other items in the uplink catalog. The translation is accurate and appropriate for the game context.
A minor suggestion to improve clarity:
Consider changing the description to:
-uplink-implanter-desc = Продвинутый имплантер, позволяющий быстро вкалывать и вытаскивать импланты. +uplink-implanter-desc = Продвинутое устройство, позволяющее быстро вживлять и извлекать импланты.This slight rewording maintains the meaning while using more precise terms in Russian for implanting and removing.
Resources/Prototypes/_White/Catalog/uplink_catalog.yml (1)
63-63: Add a newline character at the end of the fileTo adhere to common file formatting practices and resolve the yamllint error, please add a newline character at the end of the file.
You can do this by ensuring there's an empty line at the end of the file in your text editor.
🧰 Tools
🪛 yamllint
[warning] 63-63: wrong indentation: expected 4 but found 2
(indentation)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (6)
- Resources/Locale/en-US/_white/store/uplink-catalog.ftl (1 hunks)
- Resources/Locale/ru-RU/_white/prototypes/entities/objects/misc/implanters.ftl (1 hunks)
- Resources/Locale/ru-RU/_white/store/uplink-catalog.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/entities/objects/misc/implanters.ftl (0 hunks)
- Resources/Prototypes/_White/Catalog/uplink_catalog.yml (1 hunks)
- Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml (1 hunks)
💤 Files with no reviewable changes (1)
- Resources/Locale/ru-RU/prototypes/entities/objects/misc/implanters.ftl
🧰 Additional context used
🪛 yamllint
Resources/Prototypes/_White/Catalog/uplink_catalog.yml
[warning] 63-63: wrong indentation: expected 4 but found 2
(indentation)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml
[error] 12-12: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml (1)
1-12: LGTM! The ImplanterSyndi entity is well-defined.The entity definition for ImplanterSyndi looks good. It properly inherits from the Implanter parent, has a clear description, and includes appropriate components (Item, Sprite, and Implanter) with relevant properties. The use of the same sprite file for both Item and Sprite components ensures visual consistency.
🧰 Tools
🪛 yamllint
[error] 12-12: no new line character at the end of file
(new-line-at-end-of-file)
Resources/Prototypes/_White/Catalog/uplink_catalog.yml (2)
53-53: LGTM: Improved indentation forsaleLimitThe indentation adjustment for the
saleLimitfield improves code formatting and consistency, aligning with YAML best practices.
Line range hint
1-63: Overall assessment: Good addition with minor formatting improvements neededThe addition of the
UplinkImplanterSyndilisting aligns well with the PR objectives. The changes are generally good, introducing the new syndicate implanter to the uplink catalog. A few minor formatting adjustments have been suggested to maintain consistency with the rest of the file.To summarize the review:
- The indentation of the
saleLimitfield forUplinkBetrayalKnifehas been improved.- The new
UplinkImplanterSyndilisting has been added successfully.- Minor indentation adjustment is needed for the
categoriesfield in the new listing.- Consider adding an
iconfield to the new listing if applicable.- A newline character should be added at the end of the file.
Once these minor issues are addressed, the changes will be fully consistent with the existing structure and ready for merge.
🧰 Tools
🪛 yamllint
[warning] 52-52: wrong indentation: expected 8 but found 6
(indentation)
[warning] 63-63: wrong indentation: expected 4 but found 2
(indentation)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml (1)
12-12: Add a newline at the end of the file.To adhere to YAML best practices and resolve the static analysis warning, please add a newline at the end of the file.
🧰 Tools
🪛 yamllint
[error] 12-12: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml (1 hunks)
🧰 Additional context used
🪛 yamllint
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml
[error] 12-12: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml (1)
1-4: Consider updating the description as per previous review.The entity definition looks good. However, there's a previous suggestion to modify the description slightly. Consider updating it to:
description: A compact disposable syringe exclusively designed for the quick injection and extraction of subdermal implants.This change adds more specificity to the description, which could be beneficial for players.
Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
- Resources/Locale/en-US/_white/store/uplink-catalog.ftl (1 hunks)
- Resources/Locale/ru-RU/_white/prototypes/entities/objects/misc/implanters.ftl (1 hunks)
- Resources/Locale/ru-RU/_white/store/uplink-catalog.ftl (1 hunks)
- Resources/Prototypes/_White/Catalog/uplink_catalog.yml (2 hunks)
- Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- Resources/Locale/en-US/_white/store/uplink-catalog.ftl
- Resources/Locale/ru-RU/_white/prototypes/entities/objects/misc/implanters.ftl
- Resources/Locale/ru-RU/_white/store/uplink-catalog.ftl
- Resources/Prototypes/_White/Entities/Objects/Misc/implanters.yml
🧰 Additional context used
🪛 yamllint
Resources/Prototypes/_White/Catalog/uplink_catalog.yml
[error] 62-62: trailing spaces
(trailing-spaces)
[warning] 63-63: wrong indentation: expected 4 but found 2
(indentation)
[warning] 74-74: wrong indentation: expected 4 but found 2
(indentation)
🔇 Additional comments (1)
Resources/Prototypes/_White/Catalog/uplink_catalog.yml (1)
Line range hint
55-74: Overall assessment: Changes look good with minor improvements suggestedThe addition of the
UplinkImplanterSyndilisting and the updates to existing entries align well with the PR objectives. The changes maintain the overall structure and consistency of the uplink catalog.To further improve the code:
- Address the indentation issues for the
categoriesfields.- Remove trailing spaces.
- Consider adding an
iconfield for the new listing if applicable.Once these minor adjustments are made, the changes will be ready for merging.
🧰 Tools
🪛 yamllint
[warning] 52-52: wrong indentation: expected 8 but found 6
(indentation)
[error] 62-62: trailing spaces
(trailing-spaces)
[warning] 63-63: wrong indentation: expected 4 but found 2
(indentation)
Описание PR
Порт имплантера синдиката
Изменения
🆑 Spatison