[Fix] Fix some Locales Seemingly Made Using Google Translate #82
Conversation
WalkthroughThis pull request includes modifications to localization strings in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Resources/Locale/en-US/_white/ghost/ghost-respawn.ftl (1)
7-7: LGTM with suggestion: Improved clarity in rules footerThe rephrasing of the rules footer significantly improves clarity. It now provides a clear warning about the consequences of using knowledge from a previous character and directs users to the server rules for more details. The use of colored text effectively emphasizes important parts of the message.
Consider adding a space after the comma in "Please, read" for better readability:
-ghost-respawn-window-rules-footer = By respawning, you [color=#ff7700]agree[/color] [color=#ff0000]not to use any knowledge gained as your previous charactrer[/color]. Violation of this rule may constitute a server ban. Please, read the server rules for more details. +ghost-respawn-window-rules-footer = By respawning, you [color=#ff7700]agree[/color] [color=#ff0000]not to use any knowledge gained as your previous charactrer[/color]. Violation of this rule may constitute a server ban. Please, read the server rules for more details.Also, there's a typo in "charactrer" which should be corrected to "character".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- Resources/Locale/en-US/_white/ghost/ghost-respawn.ftl (1 hunks)
🧰 Additional context used
🔇 Additional comments (6)
Resources/Locale/en-US/_white/ghost/ghost-respawn.ftl (6)
1-4: LGTM: Improved clarity in respawn time messageThe rephrasing of this message is clearer and more direct, emphasizing the need to wait before attempting to respawn. The pluralization logic is correctly maintained, ensuring proper grammar for both singular and plural cases.
5-5: LGTM: Enhanced clarity in max players messageThe revised message is more precise and informative. It clearly communicates the current inability to respawn and the condition for respawning (fewer than a specific number of players). This change improves user understanding of the respawn mechanics.
6-6: LGTM: Simplified window titleThe simplification of the window title from "Rules for returning to the round" to "Respawn rules" is a good improvement. It's more concise while maintaining the essential meaning, which enhances readability and user understanding.
8-8: LGTM: Improved guidance for character selectionThe updated message provides clearer instructions to the user. It now specifically directs them to select a different character in their preferences, which is more actionable and helpful for users encountering this situation.
9-12: LGTM: Enhanced clarity in log messageThe adjustments to this log message improve grammatical consistency and clarity. The phrasing "after respawning with a similar name" is more natural and precise. The conditional logic for "joined" or "tried to join" is correctly maintained, ensuring appropriate logging for different scenarios.
1-12: Overall: Significant improvements in clarity and localization qualityThe changes in this file consistently enhance the clarity and user-friendliness of the ghost respawn messages. The modifications address the PR objective of fixing locales that appeared to be made using Google Translate. The rephrased messages are more natural, precise, and informative, which should improve the user experience and understanding of the ghost respawn mechanics.
To ensure consistency across other locales, please run the following script:
This script will help identify any inconsistencies or missing translations in other locale files that may need to be addressed in future PRs.
✅ Verification successful
Verification Complete: Localization Consistency Confirmed
The script results indicate that all key strings in
ghost-respawn.ftlare present in bothen-USandru-RUlocales. No inconsistencies or missing translations were found, ensuring localization quality across the supported languages.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for inconsistencies in ghost-respawn.ftl across different locales # Find all ghost-respawn.ftl files files=$(fd -t f "ghost-respawn.ftl" Resources/Locale) # Compare the number of lines in each file for file in $files; do echo "File: $file" wc -l "$file" done # Check for the presence of key strings in all files key_strings=("ghost-respawn-time-left" "ghost-respawn-max-players" "ghost-respawn-window-title" "ghost-respawn-window-rules-footer" "ghost-respawn-same-character" "ghost-respawn-log-character-almost-same") for string in "${key_strings[@]}"; do echo "Checking for '$string' in all files:" rg -l "$string" $files doneLength of output: 3447
|
это будет при полном мерже EE |
Описание PR
#1006