[Tweak] Secret / Секрет

[Spatison]

Описание PR

Изменены шансы режимов. Каждый второй раунд не будет запускаться с выживания

---

Изменения

🆑 Spatison

• tweak: Changed the chances of secret modes / Изменены шансы режимов в секрете

[coderabbitai]

Walkthrough

The pull request modifies the weight configurations in the secret_weights.yml file, adjusting the weights assigned to various categories for a weighted random selection. Significant changes include a decrease in the weight for "Survival" and increases for "Nukeops," "Zombie," and "Traitor." Two new categories, "Revolutionary" and "Extended," have been added, along with "AllAtOnce." The previous weight for "Pirates" has been commented out and is no longer active in the configuration.

Changes

File	Change Summary
Resources/Prototypes/secret_weights.yml	Updated weights for categories: Survival (0.44 to 0.05), Nukeops (0.14 to 0.20), Zombie (0.03 to 0.10), Traitor (0.39 to 0.45). Added new categories: Revolutionary (0.15), Extended (0.04), AllAtOnce (0.01). Commented out previous weight for Pirates.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a8c9bbf and 549f02c.

📒 Files selected for processing (1)

• Resources/Prototypes/secret_weights.yml (1 hunks)

🧰 Additional context used

🔇 Additional comments (8)

Resources/Prototypes/secret_weights.yml (8)

5-5: Approved: Moderate increase in Nukeops mode frequency

The weight for Nukeops mode has been increased from 0.14 to 0.20. This change appears reasonable and may add more variety to the game without overshadowing other modes.

---

8-8: Traitor mode now the most frequent

The weight for Traitor mode has been increased from 0.39 to 0.45, making it the most common mode. This change could significantly alter the overall feel of the game.

It's important to consider the implications of this change. Let's check for any existing player feedback or discussions about the Traitor mode:

#!/bin/bash
# Search for any mentions of Traitor mode in issue discussions or comments
gh issue list --search "Traitor mode" --json number,title,body --jq '.[] | "Issue #\(.number): \(.title)\n\(.body)\n"'
gh pr list --search "Traitor mode" --json number,title,body --jq '.[] | "PR #\(.number): \(.title)\n\(.body)\n"'

---

7-7: New mode added: Revolutionary

A new "Revolutionary" mode has been introduced with a weight of 0.15. This addition wasn't mentioned in the PR objectives.

Could you provide more information about this new mode? It's important to ensure it has been properly tested and balanced. Let's check for any related documentation or test files:

#!/bin/bash
# Search for any mentions of Revolutionary mode in documentation or test files
rg -i "revolutionary.*mode" --type md --type cs

---

9-9: New mode added: Extended

An "Extended" mode has been introduced with a low weight of 0.04. This addition wasn't mentioned in the PR objectives.

Could you provide more information about this new mode and its intended frequency? Let's check for any related documentation or discussions:

#!/bin/bash
# Search for any mentions of Extended mode in documentation or discussions
rg -i "extended.*mode" --type md --type cs
gh issue list --search "Extended mode" --json number,title,body --jq '.[] | "Issue #\(.number): \(.title)\n\(.body)\n"'

---

6-6: Significant increase in Zombie mode frequency

The weight for Zombie mode has been notably increased from 0.03 to 0.10. While this adds more variety to the game, it's a substantial change that could significantly alter the gameplay experience.

It would be prudent to monitor the impact of this change. Consider implementing a system to track mode frequencies and player feedback:

#!/bin/bash
# Search for any existing analytics or feedback systems
rg -i "analytics|feedback|tracking" --type yaml --type cs

---

10-10: New mode added: AllAtOnce

An "AllAtOnce" mode has been introduced with a very low weight of 0.01. This addition wasn't mentioned in the PR objectives and its name suggests it could be a significant gameplay change.

Could you provide more information about this new mode, its mechanics, and the reasoning behind its very low frequency? Let's check for any related code or discussions:

#!/bin/bash
# Search for any mentions of AllAtOnce mode in code or discussions
rg -i "allatonce.*mode" --type cs
gh issue list --search "AllAtOnce mode" --json number,title,body --jq '.[] | "Issue #\(.number): \(.title)\n\(.body)\n"'

---

4-10: Significant overhaul of game mode distribution

The changes in this file represent a major shift in the game's mode distribution:

1. Survival mode has been drastically reduced (0.44 to 0.05).
2. Traitor mode is now the most common (0.39 to 0.45).
3. Three new modes have been introduced (Revolutionary, Extended, AllAtOnce).
4. The Pirates mode has been commented out.

While these changes align with the PR objective of altering the chances of secret modes, they go beyond what was initially described. Such a significant overhaul could have unforeseen impacts on gameplay and player satisfaction.

Consider a more gradual approach to these changes, allowing for player feedback and adjustment. It would be beneficial to implement a system for tracking mode frequencies and gathering player feedback. Let's check if such a system exists:

#!/bin/bash
# Search for any existing analytics or feedback systems
rg -i "mode.*frequency|player.*feedback|gameplay.*analytics" --type cs

Additionally, it might be helpful to review any recent discussions about game balance or mode distribution:

#!/bin/bash
# Search for recent discussions about game balance or mode distribution
gh issue list --search "game balance mode distribution" --state all --limit 5 --json number,title,body --jq '.[] | "Issue #\(.number): \(.title)\n\(.body)\n"'

---

4-4: Significant reduction in Survival mode frequency

The weight for Survival mode has been drastically reduced from 0.44 to 0.05. While this aligns with the PR objective of not starting every second round with survival mode, such a significant reduction might make this mode too infrequent. Consider whether this extreme change might disappoint players who enjoy the Survival mode.

To assess the impact, let's check if there are any player feedback or discussions related to the Survival mode:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Kutosss]

Вот это надо! И как можно скорее. Онлайн упал до нуля, буквально из-за невозможности играть без педалей, которые поставят гриншифт.

[TokiJumper]

Вот это надо! И как можно скорее. Онлайн упал до нуля, буквально из-за невозможности играть без педалей, которые поставят гриншифт.

Да-да. Это и есть главная причина, почему онлайн на нуле. XD

[Kutosss]

Да-да. Это и есть главная причина, почему онлайн на нуле. XD

Это одна из причин, а так вместо нуля была бы единица. Я периодически вижу как люди заходят, видят насер - выходят. Ну и собсна они сами говорили почему выходят.