Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with the newer react version 16.2.0 #5

Open
kuul13 opened this issue Feb 7, 2018 · 2 comments · May be fixed by #6
Open

Doesn't work with the newer react version 16.2.0 #5

kuul13 opened this issue Feb 7, 2018 · 2 comments · May be fixed by #6

Comments

@kuul13
Copy link

kuul13 commented Feb 7, 2018

I have installed react-dc in my project that uses
"react": "^16.2.0",
"react-dc": "^1.0.6",
"react-dom": "^16.2.0"

It throws error "TypeError: Cannot convert null or undefined to object" in ./node_modules/react-dc/dist/module/mixins/color-mixin.js at the following location:

4 | const { arrayOf, func, number, string } = React.PropTypes;

Can the dependencies be updated to the latest?
@tzs34
Copy link

tzs34 commented Mar 8, 2018

The React.PropTypes has been removed see the React website
React.PropTypes has moved into a different package since React v15.5. Please use the prop-types library instead.

So the mixins throw errors . You could use a earlier version.
But I'd like to contribute to this library as dc.js is great.

@madbonkey madbonkey linked a pull request May 11, 2018 that will close this issue
Open
@madbonkey
Copy link

@kuul13 You should be able to work around your issue temporarily by updating npm to the latest version. Looks like yours can't handle multiple versions of a dependency yet – I have npm 6.0.1 on macOS and projects with dependencies like yours do compile. Using 5.x, it won't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

React 16.3.2, prop-types madbonkey/react-dc
3 participants
@madbonkey @kuul13 @tzs34