Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename keyserver to keys-server in strings #115

Merged

Conversation

xav
Copy link
Contributor

@xav xav commented Aug 24, 2023

Description

Rename keyserver to keys-server in human-readable strings.
Resource strings are kept untouched since that would force us to redeploy the whole infra.

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@xav xav requested a review from Elyniss August 24, 2023 09:13
@xav xav linked an issue Aug 24, 2023 that may be closed by this pull request
@xav xav temporarily deployed to prod August 24, 2023 09:16 — with GitHub Actions Inactive
@xav xav temporarily deployed to staging August 24, 2023 09:16 — with GitHub Actions Inactive
@xav xav force-pushed the 114-change-human-readable-instances-of-keyserver-to-keys-server branch from ebdcd72 to 35a4ac9 Compare August 24, 2023 09:20
@xav xav temporarily deployed to prod August 24, 2023 09:21 — with GitHub Actions Inactive
@xav xav temporarily deployed to staging August 24, 2023 09:21 — with GitHub Actions Inactive
@xav xav merged commit 5798196 into master Aug 24, 2023
14 checks passed
@xav xav deleted the 114-change-human-readable-instances-of-keyserver-to-keys-server branch August 24, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change human-readable instances of "Keyserver" to "Keys Server"
2 participants