Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: geo-blocking #141

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat: geo-blocking #141

merged 1 commit into from
Oct 2, 2023

Conversation

xav
Copy link
Contributor

@xav xav commented Sep 30, 2023

Description

Integrates the geoblocking feature from utils-rs. Currently blocked countries: KP, IR, CU, SY.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@xav xav linked an issue Sep 30, 2023 that may be closed by this pull request
feat: Add OFAC blocking #140
Closed
@xav xav requested a review from Elyniss as a code owner September 30, 2023 04:44
@xav xav temporarily deployed to staging September 30, 2023 06:46 — with GitHub Actions Inactive
@xav xav temporarily deployed to prod September 30, 2023 06:46 — with GitHub Actions Inactive
@xav xav temporarily deployed to staging September 30, 2023 07:00 — with GitHub Actions Inactive
@xav xav temporarily deployed to prod September 30, 2023 07:00 — with GitHub Actions Inactive
@xav xav requested a review from heilhead September 30, 2023 07:03
heilhead
heilhead reviewed Oct 1, 2023
View reviewed changes
rustfmt.toml Show resolved Hide resolved
heilhead
heilhead approved these changes Oct 1, 2023
View reviewed changes
Copy link

@heilhead heilhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have all the same questions and concerns as in the other PR.

@xav xav merged commit ce83b63 into master Oct 2, 2023
13 checks passed
@xav xav deleted the 140-feat-add-ofac-blocking branch October 2, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heilhead heilhead heilhead approved these changes

@Elyniss Elyniss Awaiting requested review from Elyniss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add OFAC blocking
2 participants
@xav @heilhead