Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EIP-1271 #167

Merged
merged 3 commits into from
Feb 5, 2024
Merged

feat: EIP-1271 #167

merged 3 commits into from
Feb 5, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Jan 31, 2024

Description

Replaces CACO logic with library version that Notify Server is using. This adds support for EIP-1271.

  • project_id Terraform variable added to prod and staging workspace. 2 new projects were made for each.
  • Merge WalletConnectRust PR & use versioned

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

Copy link
Contributor

@Elyniss Elyniss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would love to test it on staging

@@ -1,6 +1,7 @@
PORT=8080
LOG_LEVEL=INFO
DATABASE_URL=mongodb://admin:admin@mongo:27017/keyserver?authSource=admin
PROJECT_ID=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on setting this up!

@chris13524 chris13524 merged commit 50c1b9e into master Feb 5, 2024
13 checks passed
@chris13524 chris13524 deleted the feat/eip1271 branch February 5, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants