Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clippy): fixing updated clippy dead code warnings #344

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix(clippy): fixing updated clippy dead code warnings #344

merged 1 commit into from
Jun 21, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Jun 20, 2024 •
edited
Loading

Description

This PR shadowing code parts behind feature flags, to fix the new Clippy version warnings.

How Has This Been Tested?

  • No clippy warnings/errors on cargo clippy --features=multitenant --tests -- -D warnings
  • No clippy warnings/errors on cargo clippy --tests -- -D warnings

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jun 20, 2024
@arein arein added the accepted The issue has been accepted into the project label Jun 20, 2024
@geekbrother geekbrother marked this pull request as ready for review June 20, 2024 16:45
@geekbrother geekbrother merged commit 5d201d8 into main Jun 21, 2024
6 checks passed
@geekbrother geekbrother deleted the fix/updated_clippy_warnings branch June 21, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@nopestack nopestack Awaiting requested review from nopestack

Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekbrother @chris13524 @arein