fix(apns): proper catching of Unknown CA error
#345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a proper catching of the
received fatal alert: UnknownCA.We already have matching for this kind of error, but it was added to the wrong APNS Error.
Instead of being in the
ConnectionErrorit should be in theClientErrorbecause the error appears in theClientErrorerror type. The full error log:Apns(ClientError(Error { kind: SendRequest, source: Some(hyper::Error(Io, Custom { kind: InvalidData, error: "received fatal alert: UnknownCA" })) }))How Has This Been Tested?
Not tested.
Due Diligence