Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use turbo get instead of getEnforcing in native module #5468

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

ignaciosantise
Copy link
Contributor

Description

getEnforcing was failing in a brand new expo project with new architecture enabled. Replaced getEnforcing with get in the native module spec

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Tested on sample dapp with new architecture enabled and on brand new expo project

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@ignaciosantise ignaciosantise merged commit 7039362 into v2.0 Oct 31, 2024
9 checks passed
@ignaciosantise ignaciosantise deleted the fix/rn-compat-newarch branch October 31, 2024 12:46
@ganchoradkov ganchoradkov mentioned this pull request Nov 5, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants