Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idolise Magic reform faith fix #1484

Merged

Conversation

Kumole
Copy link
Contributor

@Kumole Kumole commented Sep 29, 2024

Updated triggers to allow specific Idolised Magic type when reforming faiths that already have the doctrine.

Fix for this issue: #308

Changelog:

  • Fixed an issue where certain faiths couldn't be reformed with already held Idolised doctrines

Developer changelog:

  • Added trigger to allow faiths with preexisting idolised magic doctrines to reform with current doctrines.
  • Faiths with Idolised magic doctrines can now only change to "Accepted" when reforming,

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

Updated triggers to allow for Idolised Magic when reforming faiths that already have the doctrine
@Kumole Kumole mentioned this pull request Sep 29, 2024
@Kumole Kumole changed the title Idolise Magic triggers Idolise Magic Reform fix Sep 29, 2024
@Kumole Kumole changed the title Idolise Magic Reform fix Idolise Magic reforming fix Sep 29, 2024
@Kumole Kumole changed the title Idolise Magic reforming fix Idolise Magic reform faith fix Sep 29, 2024
Copy link
Contributor

@helloruhe helloruhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@helloruhe helloruhe merged commit 44cef4c into Warcraft-GoA-Development-Team:dev Sep 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants