Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsconfig support #33

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Fix tsconfig support #33

merged 7 commits into from
Jun 17, 2024

Conversation

WarningImHack3r
Copy link
Owner

@WarningImHack3r WarningImHack3r commented Apr 5, 2024

Fixes #32.

Widen tolerance of the Json constructor to allow JSON5 features, unlocking support for tsconfig.json files with comments (and more).

Waiting for a release including Kotlin/kotlinx.serialization#2592 to merge.

@WarningImHack3r WarningImHack3r self-assigned this Apr 5, 2024
@WarningImHack3r WarningImHack3r marked this pull request as draft April 6, 2024 16:54
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.5
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@WarningImHack3r WarningImHack3r marked this pull request as ready for review June 17, 2024 21:23
@WarningImHack3r WarningImHack3r merged commit fa49703 into main Jun 17, 2024
5 of 6 checks passed
@WarningImHack3r WarningImHack3r deleted the tsconfig-fix branch June 17, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crash] Parsing error when processing a tsconfig file with comments
1 participant