Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect with GitHub #27

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Connect with GitHub #27

merged 10 commits into from
Aug 26, 2024

Conversation

WarningImHack3r
Copy link
Owner

@WarningImHack3r WarningImHack3r commented Aug 24, 2024

My tweet announcing the new feature finally allowing to get rid of the rate-limit issue received an answer from @paoloricciuti, suggesting the use of the Login with GitHub feature through Lucia Auth.

I didn’t think about it at all, and after discussing it more with the creator of Lucia himself, I realized that it could be a doable solution.

So here we are. Getting everything up and running might take a bunch of time, but it'll be a much better experience than a token!

Progress

Additional related changes

  • Add a new CI script to make check bypass inexistent env var in CI
  • Switch to svelte-persisted-store instead of the local localStorageStore

@WarningImHack3r WarningImHack3r self-assigned this Aug 24, 2024
Copy link

vercel bot commented Aug 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 10:30pm

- Add Sonner for login and logout
- Add token stats like before
- Use svelte-persisted-store instead of an old local version
- Other small tweaks
@WarningImHack3r WarningImHack3r merged commit 5c32a7b into main Aug 26, 2024
4 checks passed
@WarningImHack3r WarningImHack3r deleted the login-with-gh branch August 26, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant