Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous colour chart #78

Merged
merged 24 commits into from
Dec 7, 2021
Merged

Conversation

edwardchalstrey1
Copy link
Member

@edwardchalstrey1 edwardchalstrey1 commented Dec 6, 2021

Closes #63

  • Make sure y axis of colour plot lines up with histogram plot for imdb scatter example opened new issue Colours used: scatterplot example goes beyond data range #82
  • Update test for continuous scale plot TestMetaHist.test_scatterplot_bin_False
  • Update all tests due to change in title and y axis labelling on colours used/ density plots
  • Merge develop into this branch
  • Refactor

@edwardchalstrey1
Copy link
Member Author

@rolyp I think it might be impossible to plot the continuous scale properly on the colours used plot - this solution is almost there but doesn't look quite right, I think if I can't find a solution today though it may be worth just merging anyway to focus on finishing the notebooks and opening a new issue like "make continuous colour scale look fully continuous"

@rolyp
Copy link
Collaborator

rolyp commented Dec 6, 2021

Ok, I'll take a look now.

@rolyp I think it might be impossible to plot the continuous scale properly on the colours used plot - this solution is almost there but doesn't look quite right, I think if I can't find a solution today though it may be worth just merging anyway to focus on finishing the notebooks and opening a new issue like "make continuous colour scale look fully continuous"

@edwardchalstrey1
Copy link
Member Author

Ok, I'll take a look now.

@rolyp I think it might be impossible to plot the continuous scale properly on the colours used plot - this solution is almost there but doesn't look quite right, I think if I can't find a solution today though it may be worth just merging anyway to focus on finishing the notebooks and opening a new issue like "make continuous colour scale look fully continuous"

@rolyp this seems to be almost there, the y ticks on the "colours used" chart seem to not exactly line up for the continuous scatter plot, must be some small tweak I can make here that I'm yet to figure out

@rolyp
Copy link
Collaborator

rolyp commented Dec 6, 2021

@edwardchalstrey1 Replied on Slack but probably better to put it here.) Yes, I see what you mean re. the ticks not lining up 😞 I vaguely recall that being a problem we "solved" by setting nice=True! Let's experiment a bit more -- the ticks lining up is I guess a non-optional feature, but it does seem annoying that we can't force that (other than by reverting the nice setting).

@edwardchalstrey1 edwardchalstrey1 marked this pull request as ready for review December 7, 2021 14:48
@edwardchalstrey1 edwardchalstrey1 merged commit 43275f1 into develop Dec 7, 2021
@edwardchalstrey1 edwardchalstrey1 deleted the continuous-color-chart branch December 7, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "colours used" chart still appear for continuous color scale
2 participants