-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added links to plugins #174
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the Pull Request titled "Added links to plugins" involves adding links to plugins in the documentation files. The changes seem to be straightforward and do not introduce any significant problems. However, there are some potential issues and errors that need attention:
These potential issues should be addressed to improve the quality and accuracy of the documentation. DetailsCommit a3d00589d362c0bd472071b4345dee17b9dc94f5Key changes in this patch:
Potential problems:
Overall, the changes seem to be straightforward and do not introduce any significant problems. Commit c2f13be382ceb8fdfc0fda957c4dea456a212b3dKey changes:
Potential problems:
Overall, the patch adds links to the currently released plugins in the documentation. It appears to be a straightforward addition with no potential issues. Commit 59e3fca88dddb88c98b56c4361e71a23f0fde8abKey changes:
Potential problems:
Overall, the changes seem to be straightforward and do not introduce any major issues. However, it would be beneficial to clarify the reasons for changing the links to relative paths. Commit e2835826824d759b00170e0907c69610009c9d0bKey changes:
Potential problems:
Commit eeb592420fd9d01bb0d8ca99659d622ab11010f8Key changes:
Potential problems:
Commit ab66a33003df998c3acd50509b1495e82b5d6446Key changes:
Potential problems:
Overall, the patch resolves a merge conflict in the Commit 0911d59d2ae8e101d46ade91180633f3bce6f78dKey changes:
Potential problems:
Overall, the changes in this patch are minimal and do not introduce any problems. Commit 3887bdf71166532cce9fddebbdb77031cda9eb8dKey Changes:
Potential Problems:
Overall, the patch seems to add new plugins and update existing ones, but there are some missing links and unclear platform support. Commit feec71c8fc6379a1912a3bfb05dd168777452c5eThe key changes in this patch include fixing spacing in the plugins.md file. The changes involve adding or removing whitespace in certain lines. The potential problem in this patch is that it doesn't seem to address any functional issues or add any new features. It only modifies whitespace, which may not be a significant change. It's important to note that without additional context or information, it's difficult to determine the exact purpose or intent of this patch. However, based on the provided information, it appears to be a minor formatting or cosmetic change. Commit 98837781f7ccd41216145d025daf76c5fe3e7fdcKey Changes:
Potential Problems:
Commit cfcdd13f36f4d8f63e4f5b60df23472ee6b87056Key Changes:
Potential Problems:
Commit 110082835e59a5c3b22f502977ff1d365ac3fa6dKey changes:
Potential problems:
|
Hi @alabulei1 , should I add links to the plugins on https://wasmedge.org/docs/contribute/plugin/intro#wasmedge-currently-released-plug-ins ? |
@Mash707 Yes, please. Sorry for the delay. Though I am not a maintainer, this sounds like a welcoming change, could you please add the links to the page you suggested as well? |
Sure, will add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alabulei1 @hydai Could you please take another look at this PR?
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
docs/contribute/plugin/intro.md
Outdated
| WasmEdge-Tensorflow | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-Tensorflow](../source/plugin/tensorflow.md) | | ||
| WasmEdge-TensorflowLite | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-TensorflowLite](../source/plugin/tensorflowlite.md) | | ||
| [WasmEdge-Image](../source/plugin/image.md) | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-Image](../source/plugin/image.md) | | ||
| [WasmEdge-Tensorflow](../../develop/rust/wasinn/tf_plugin.md) | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-Tensorflow](../source/plugin/tensorflow.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed the link.
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Adithya Krishna <aadithya794@gmail.com> Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
I will open a new PR for this issue , this PR got a little messy with merge conflicts which I am unable to resolve. |
#163