Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links to plugins #174

Closed
wants to merge 15 commits into from
Closed

Added links to plugins #174

wants to merge 15 commits into from

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Oct 1, 2023

Copy link
Collaborator

alabulei1 commented Oct 1, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, the Pull Request titled "Added links to plugins" involves adding links to plugins in the documentation files. The changes seem to be straightforward and do not introduce any significant problems. However, there are some potential issues and errors that need attention:

  • In one of the patches, some of the links are not properly formatted.
  • It's unclear why some links have been changed to relative paths while others have not.
  • The information regarding platform support and language support for the plugins is incomplete or inconsistent.
  • The "Old WasmEdge Extensions" section is not modified or removed, even though the patch is titled "Added relative links".
  • There are missing links for new plugins and unclear platform support for existing plugins.

These potential issues should be addressed to improve the quality and accuracy of the documentation.

Details

Commit a3d00589d362c0bd472071b4345dee17b9dc94f5

Key changes in this patch:

  • Links to the plugins have been added in the documentation file docs/start/wasmedge/extensions/plugins.md.
  • The links provide information about the description, platform support, language support, and documentation of each plugin.

Potential problems:

  • None of the links are broken or malformed.
  • The formatting and alignment of the table could be improved for better readability.

Overall, the changes seem to be straightforward and do not introduce any significant problems.

Commit c2f13be382ceb8fdfc0fda957c4dea456a212b3d

Key changes:

  • Added links to various plugins in the "currently released plugin" section in the docs/contribute/plugin/intro.md file.

Potential problems:

  • None

Overall, the patch adds links to the currently released plugins in the documentation. It appears to be a straightforward addition with no potential issues.

Commit 59e3fca88dddb88c98b56c4361e71a23f0fde8ab

Key changes:

  • Updated the links to the plugins in the intro.md file.
  • Changed the links to use relative paths instead of absolute paths.

Potential problems:

  • It seems that the links to the plugins have been changed to relative paths without any explanation or justification. It would be helpful to have an explanation in the pull request description or in a comment within the code.
  • The links themselves appear to be correctly updated to point to the appropriate plugin files.

Overall, the changes seem to be straightforward and do not introduce any major issues. However, it would be beneficial to clarify the reasons for changing the links to relative paths.

Commit e2835826824d759b00170e0907c69610009c9d0b

Key changes:

  • Relative links have been added to the existing list of WasmEdge official released plug-ins.

Potential problems:

Commit eeb592420fd9d01bb0d8ca99659d622ab11010f8

Key changes:

  • Fixed a wrong link in the intro.md file in the docs/contribute/plugin/ directory.

Potential problems:

  • There doesn't seem to be any potential problems in this patch. The change appears to be straightforward and doesn't introduce any code issues.

Commit ab66a33003df998c3acd50509b1495e82b5d6446

Key changes:

  • Resolved a merge conflict.

Potential problems:

  • No potential problems found.

Overall, the patch resolves a merge conflict in the docs/start/wasmedge/extensions/plugins.md file. There don't seem to be any potential problems with the changes.

Commit 0911d59d2ae8e101d46ade91180633f3bce6f78d

Key changes:

  • This patch resolves a merge conflict in the file docs/start/wasmedge/extensions/plugins.md.
  • Specifically, it removes one line of content from the file.

Potential problems:

  • Since the patch only resolves a merge conflict and removes a line of content, there are no apparent issues or problems in this specific patch.

Overall, the changes in this patch are minimal and do not introduce any problems.

Commit 3887bdf71166532cce9fddebbdb77031cda9eb8d

Key Changes:

  • Added links to several plugins: WasmEdge-eBPF, WasmEdge-rusttls, and WasmEdge-OpenCV.
  • Updated the descriptions and language/platform support for existing plugins.

Potential Problems:

  • The links provided for the new plugins (WasmEdge-eBPF and WasmEdge-rusttls) are missing.
  • The platform support for the WasmEdge-OpenCV plugin is listed as "Unreleased," which could be a potential issue if users rely on this plugin but it is not available yet.

Overall, the patch seems to add new plugins and update existing ones, but there are some missing links and unclear platform support.

Commit feec71c8fc6379a1912a3bfb05dd168777452c5e

The key changes in this patch include fixing spacing in the plugins.md file. The changes involve adding or removing whitespace in certain lines.

The potential problem in this patch is that it doesn't seem to address any functional issues or add any new features. It only modifies whitespace, which may not be a significant change.

It's important to note that without additional context or information, it's difficult to determine the exact purpose or intent of this patch. However, based on the provided information, it appears to be a minor formatting or cosmetic change.

Commit 98837781f7ccd41216145d025daf76c5fe3e7fdc

Key Changes:

  • Two new plugins, "wasmedge-ebpf" and "wasmedge-rusttls", have been added to the list of plugins in the documentation.

Potential Problems:

  • No potential problems were identified in this patch.

Commit cfcdd13f36f4d8f63e4f5b60df23472ee6b87056

Key Changes:

  • Resolved a merge conflict in the "plugins.md" file.

Potential Problems:

  • There doesn't seem to be any major problems with this patch. However, it would be helpful to have more context about the merge conflict that was resolved.

Commit 110082835e59a5c3b22f502977ff1d365ac3fa6d

Key changes:

  • Fixed spacing in the plugins.md file.

Potential problems:

  • There don't seem to be any potential problems with this patch. It only fixes some spacing in the plugins.md file, which is a minor change and unlikely to cause any issues.

@Mash707
Copy link
Contributor Author

Mash707 commented Oct 1, 2023

@adithyaakrishna
Copy link
Contributor

@Mash707 Yes, please. Sorry for the delay. Though I am not a maintainer, this sounds like a welcoming change, could you please add the links to the page you suggested as well?

@Mash707
Copy link
Contributor Author

Mash707 commented Oct 22, 2023

@Mash707 Yes, please. Sorry for the delay. Though I am not a maintainer, this sounds like a welcoming change, could you please add the links to the page you suggested as well?

Sure, will add it.

Copy link
Contributor

@adithyaakrishna adithyaakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alabulei1 @hydai Could you please take another look at this PR?

docs/contribute/plugin/intro.md Outdated Show resolved Hide resolved
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
@Mash707 Mash707 requested a review from hydai November 1, 2023 19:32
| WasmEdge-Tensorflow | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-Tensorflow](../source/plugin/tensorflow.md) |
| WasmEdge-TensorflowLite | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-TensorflowLite](../source/plugin/tensorflowlite.md) |
| [WasmEdge-Image](../source/plugin/image.md) | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-Image](../source/plugin/image.md) |
| [WasmEdge-Tensorflow](../../develop/rust/wasinn/tf_plugin.md) | [wasmedge_tensorflow_interface][] | `manylinux2014 x86_64`, `manylinux2014 aarch64`, `ubuntu 20.04 x86_64`, `darwin x86_64`, and `darwin arm64` (since `0.13.0`) | [Build With WasmEdge-Tensorflow](../source/plugin/tensorflow.md) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the link.

Mash707 and others added 11 commits November 3, 2023 16:43
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
Signed-off-by: Divyanshu GUpta <divyanshugupta585@gmail.com>
@Mash707
Copy link
Contributor Author

Mash707 commented Nov 3, 2023

I will open a new PR for this issue , this PR got a little messy with merge conflicts which I am unable to resolve.

@Mash707 Mash707 closed this Nov 3, 2023
@Mash707 Mash707 deleted the adding-links-to-plugins branch November 3, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants