-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install.md #184
Update install.md #184
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the patch for updating the "install.md" file seems to have some potential issues and errors that should be addressed. Firstly, the patch only translates the content into Chinese without updating the English version. This means that the English version will become outdated if the changes from the patch are merged. It would be ideal to have both versions updated to ensure consistency. Secondly, the addition of the "{{ wasmedge_version }}" placeholder in the command example is unclear. The purpose or intent of this placeholder should be clarified or removed if unnecessary. Thirdly, the link added in the note section is not functional in the diff. It should be fixed to point to the correct location within the repository. Lastly, the inclusion of the merge commit message in the diff does not seem necessary and should be removed from the patch. Overall, the patch has some potential issues that need to be addressed. Once these issues are resolved, the patch's changes can improve the Chinese translation of the "install.md" file and update related command examples and explanations. DetailsCommit ae2e454da1a019872b2034d676f9f41db014aafdKey changes in the patch:
Potential problems:
Commit 8e3076d962d0662bb74434814d3f9c33da5103b4The key change in this patch is an update to the There don't seem to be any potential problems with this patch. It is a simple fix that resolves an incorrect URL. Commit f9b5dffafbee804b151498f74aba59dfea64e4fbKey changes:
Potential problems:
Overall, the changes seem to improve the Chinese translation of the |
07ea578
to
96be69c
Compare
i18n/zh/docusaurus-plugin-content-docs/current/start/install.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/install.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/start/install.md
Outdated
Show resolved
Hide resolved
Hi @ezirmusitua Please check out my comments. Thanks |
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
Signed-off-by: ezirmusitua <jferroal@gmail.com>
07a7f3c
to
f9b5dff
Compare
Explanation
Add zh-cn translation
Related issue
N/A
What type of PR is this
/kind documentation
Proposed Changes
Translate i18n/zh/docusaurus-plugin-content-docs/current/start/install.md