Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors in #6. #9

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

yanghaku
Copy link
Contributor

This PR fixes the compile errors in #6. The PR uses the patches in the closed PR #8 authored by @Moon1102.
Thanks to the contributor @Moon1102(juzi 726451484@qq.com) in PR #8.

…1102(juzi <726451484@qq.com>) in PR WasmEdge#8.

Signed-off-by: yanghaku <1961882079@qq.com>
Copy link
Contributor

alabulei1 commented Jun 13, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit c6d2b331ea16a9712fb10ca39b78d0f3d2a19d37

Key Changes:

  1. Dependency Update: The patch update the Cargo.toml file to replace the rusttype dependency with ab_glyph.
  2. Font Handling: Changes were made in draw_detections.rs and default_font/mod.rs to use ab_glyph instead of rusttype for font handling.
  3. Coding Patterns: Updated some code patterns in functions related to image processing to improve maintainability.

Potential Problems:

  1. Dependency Compatibility: Make sure that the project is compatible with the ab_glyph dependency and that it works correctly in the existing code.
  2. Font Handling: While updating font handling to use ab_glyph, ensure that the font functionality still works as expected after the change.
  3. Code Patterns: Verify that the changes in code patterns do not introduce new bugs or unintended behavior. It's crucial to test these functions thoroughly.

Overall, the changes seem reasonable and focused on resolving compile errors, but thorough testing is recommended to ensure everything functions as intended.

@hydai hydai linked an issue Jun 17, 2024 that may be closed by this pull request
@hydai hydai merged commit 68462d2 into WasmEdge:main Jun 17, 2024
2 checks passed
@hydai
Copy link
Member

hydai commented Jun 17, 2024

Thanks @Moon1102 and @yanghaku

@yanghaku yanghaku deleted the fix_font_error branch June 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: could not compile mediapipe-rs
3 participants