Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contract to cosmwasm 1.1.2 #71

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update contract to cosmwasm 1.1.2 #71

wants to merge 8 commits into from

Conversation

SylvestreG
Copy link

This PR bumps dependencies to last cosmwasm dependencies.

@ben2x4 ben2x4 requested a review from 0xekez September 21, 2022 22:20
0xekez
0xekez reviewed Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@0xekez 0xekez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple little nits, then i'd be happy to land this.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
src/integration_test.rs Outdated Show resolved Hide resolved
src/integration_test.rs Outdated Show resolved Hide resolved
@0xekez
Copy link
Collaborator

0xekez commented Oct 7, 2022

so it looks like the last failure here is that const-old which is a dependency of cosmwasm-crypto is on the 2021 edition of rust. as we can't get around that dependency, we should probably upgrade our github action here to use nightly.

@SylvestreG would you mind updating that? can probably literally copy-paste the DAO DAO workflow from here.

@SylvestreG
Copy link
Author

so it looks like the last failure here is that const-old which is a dependency of cosmwasm-crypto is on the 2021 edition of rust. as we can't get around that dependency, we should probably upgrade our github action here to use nightly.

@SylvestreG would you mind updating that? can probably literally copy-paste the DAO DAO workflow from here.

Sure, just tried with 1.63.0 that should be enough :) If it not works I will bump to nightly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xekez 0xekez 0xekez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SylvestreG @0xekez