Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portman Hokkaido routine fix #1

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Watchman3001
Copy link
Owner

Jason Portman in Hokkaido has an action where he is drinking a wine at the bar area. It is the very last action before he hears the announcement (happens during the action) and goes to the clinic. Problem is, due to the typo/mistake in IDs, in vanilla game he is using an action of simply standing nearby and inspecting a sakura tree, as if his glass was destroyed. Just fixing the action ID actually restores this part of his routine. Quite a curious bug, wonder how it never got discovered

Also my first PR, so please tell me if I did something wrong. Appreciate that

Copy link

github-actions bot commented Aug 7, 2024

Hey there and thank you for opening this pull request!

Commits and pull requests for this mod follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Portman Hokkaido routine fix". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - fix
 - feat
 - enhancement
 - style
 - refactor
 - build
 - ci
 - chore

@Watchman3001 Watchman3001 merged commit 3ff8f05 into main Aug 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant