Refine Wazebar Positioning and UI Updates #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JS55CT
commented
Jan 10, 2025
JS55CT
commented
- Moved Wazebar HTML injection point from #app-head to .app.container-fluid (.show-sidebar dynamically included) to improve element positioning and layout consistency.
- Ensured compatibility by maintaining functionality with or without the 'show-sidebar' class present.
- Execution of setHeightForAppContainer() after the "SAVE" event to recalculate body > div.app.container-fluid, preventing unwanted scrollbar appearance.
- Capped Wazebar settings font size at 30 to prevent potential overflow in .app.container.
- Moved Wazebar HTML injection point from `#app-head` to `.app.container-fluid.show-sidebar` to improve element positioning. - Updated `setHeightForAppContainer()` call to execute after the "SAVE" event, ensuring the height of `body > div.app.container-fluid.show-sidebar` is recalculated, which prevents unwanted scrollbar appearance. - Set a maximum font size of 30 for the Wazebar settings to prevent potential overflow of `.app.container`. This refactor enhances UI stability by ensuring dynamic adjustments are made in response to user settings.
…-fluid (.show-sidebar dynamically included) to improve element positioning and layout consistency. - Ensured compatibility by maintaining functionality with or without the 'show-sidebar' class present. - Integrated changes from pull request WazeDev#9, including: - Execution of setHeightForAppContainer() after the "SAVE" event to recalculate body > div.app.container-fluid.show-sidebar height, preventing unwanted scrollbar appearance. - Capped Wazebar settings font size at 30 to prevent potential overflow in .app.container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.