Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smallpatches #5525

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Smallpatches #5525

merged 2 commits into from
Nov 7, 2024

Conversation

InfusOnWoW
Copy link
Contributor

No description provided.

Should hopefully fix the linked bug report

Fixes: WeakAuras#5508
Meaning remaing time checks against them always return false.

Fixes: WeakAuras#5515
@emptyrivers emptyrivers merged commit d4bb7ce into WeakAuras:main Nov 7, 2024
3 checks passed
@emptyrivers
Copy link
Contributor

of course it was only after i clicked merge that i had the thought that maybe we should teach BT2 to have an option to explicitly filter for/against "durationless" auras.

I suppose we'll see if that's something people actually want soon enough. But also perhaps total duration == 0 is sufficient anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants