Merge pull request #1953 from Web3Auth/fix/specify-modalconfig-breaks

Fix specifing modalConfig causes initError + update web3auth base hook interface in hook base package
Web3Auth · Sep 19, 2024 · 3a9433d · 3a9433d
2 parents b6862b3 + a0b59c3
commit 3a9433d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/base/src/hooks/index.ts b/packages/base/src/hooks/index.ts
@@ -6,11 +6,15 @@ import { CustomChainConfig } from "../chain/IChainInterface";
 import { IPlugin } from "../plugin";
 
 export interface IBaseWeb3AuthHookContext {
+  isInitialized: boolean;
+  isInitializing: boolean;
+  initError: unknown;
   isConnected: boolean;
+  isConnecting: boolean;
+  connectError: unknown;
   provider: IProvider | null;
   userInfo: Partial<AuthUserInfo> | null;
   isMFAEnabled: boolean;
-  isInitialized: boolean;
   status: ADAPTER_STATUS_TYPE | null;
   enableMFA(params?: LoginParams): Promise<void>;
   logout(params?: { cleanup: boolean }): Promise<void>;

diff --git a/packages/modal/src/modalManager.ts b/packages/modal/src/modalManager.ts
@@ -116,7 +116,7 @@ export class Web3Auth extends Web3AuthNoModal implements IWeb3AuthModal {
         },
       };
       if (!params?.modalConfig) params = { modalConfig: {} };
-      const localSmsOtpEnabled = params.modalConfig[WALLET_ADAPTERS.AUTH]?.loginMethods?.[LOGIN_PROVIDER.SMS_PASSWORDLESS].showOnModal;
+      const localSmsOtpEnabled = params.modalConfig[WALLET_ADAPTERS.AUTH]?.loginMethods?.[LOGIN_PROVIDER.SMS_PASSWORDLESS]?.showOnModal;
       if (localSmsOtpEnabled === true && smsOtpEnabled === false) {
         throw WalletInitializationError.invalidParams("must enable sms otp on dashboard in order to utilise it");
       }