await typed msg param validation

Web3Auth · Jul 9, 2024 · d027fc2 · d027fc2
1 parent 1f1433b
commit d027fc2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/providers/ethereum-mpc-provider/src/providers/signingProviders/signingUtils.ts b/packages/providers/ethereum-mpc-provider/src/providers/signingProviders/signingUtils.ts
@@ -204,7 +204,7 @@ export function getProviderHandlers({
         ...msgParams,
         version: SignTypedDataVersion.V1,
       };
-      validateTypedMessageParams(params, finalChainId);
+      await validateTypedMessageParams(params, finalChainId);
       const data = typeof params.data === "string" ? JSON.parse(params.data) : params.data;
       const sig = signTypedData(sign, data, SignTypedDataVersion.V1);
       return sig;
@@ -219,7 +219,7 @@ export function getProviderHandlers({
         });
       const chainId = await providerEngineProxy.request<unknown, string>({ method: "eth_chainId" });
       const finalChainId = Number.parseInt(chainId, isHexStrict(chainId) ? 16 : 10);
-      validateTypedMessageParams(msgParams, finalChainId);
+      await validateTypedMessageParams(msgParams, finalChainId);
       const data = typeof msgParams.data === "string" ? JSON.parse(msgParams.data) : msgParams.data;
       const sig = signTypedData(sign, data, SignTypedDataVersion.V3);
       return sig;
@@ -234,7 +234,7 @@ export function getProviderHandlers({
         });
       const chainId = await providerEngineProxy.request<unknown, string>({ method: "eth_chainId" });
       const finalChainId = Number.parseInt(chainId, isHexStrict(chainId) ? 16 : 10);
-      validateTypedMessageParams(msgParams, finalChainId);
+      await validateTypedMessageParams(msgParams, finalChainId);
       const data = typeof msgParams.data === "string" ? JSON.parse(msgParams.data) : msgParams.data;
       const sig = signTypedData(sign, data, SignTypedDataVersion.V4);
       return sig;

diff --git a/packages/providers/ethereum-provider/src/providers/privateKeyProviders/ethPrivatekeyUtils.ts b/packages/providers/ethereum-provider/src/providers/privateKeyProviders/ethPrivatekeyUtils.ts
@@ -84,7 +84,7 @@ export function getProviderHandlers({
         ...msgParams,
         version: SignTypedDataVersion.V1,
       };
-      validateTypedMessageParams(params, finalChainId);
+      await validateTypedMessageParams(params, finalChainId);
       const { signTypedData } = await import("@metamask/eth-sig-util");
       const data = typeof params.data === "string" ? JSON.parse(params.data) : params.data;
       const sig = signTypedData({ privateKey: privKeyBuffer, data, version: SignTypedDataVersion.V1 });
@@ -101,7 +101,7 @@ export function getProviderHandlers({
         });
       const chainId = await providerEngineProxy.request<never, string>({ method: "eth_chainId" });
       const finalChainId = Number.parseInt(chainId, isHexStrict(chainId) ? 16 : 10);
-      validateTypedMessageParams(msgParams, finalChainId);
+      await validateTypedMessageParams(msgParams, finalChainId);
       const data = typeof msgParams.data === "string" ? JSON.parse(msgParams.data) : msgParams.data;
       const { signTypedData } = await import("@metamask/eth-sig-util");
       const sig = signTypedData({ privateKey: privKeyBuffer, data, version: SignTypedDataVersion.V3 });
@@ -118,7 +118,7 @@ export function getProviderHandlers({
         });
       const chainId = await providerEngineProxy.request<never, string>({ method: "eth_chainId" });
       const finalChainId = Number.parseInt(chainId, isHexStrict(chainId) ? 16 : 10);
-      validateTypedMessageParams(msgParams, finalChainId);
+      await validateTypedMessageParams(msgParams, finalChainId);
       const data = typeof msgParams.data === "string" ? JSON.parse(msgParams.data) : msgParams.data;
       const { signTypedData } = await import("@metamask/eth-sig-util");
       const sig = signTypedData({ privateKey: privKeyBuffer, data, version: SignTypedDataVersion.V4 });