Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
sync signTypedData handler between ethereum-mpc-provider and ethereum-provider
39dddf7
question
should the developer should make sure the eip712domain is not added to the
types
or the wallet should remove it from thetypes
?currently ethers lib's TypedDataEncoder.getPayload(domain, types, value) is generating the payload with eip712domain type in the
types
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: