Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing the right targets on CI #461

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Commits on Jul 26, 2024

  1. Fix testing the right targets on CI

    This commit fixes a bug from the cmake migration where tests were not
    actually testing the correct target. Object files were compiled with the
    right options but the link step was missing both `--target` and
    `-pthread` which caused everything to accidentally be tested as
    `wasm32-wasi`. When fixing this one test was needed to have its stderr
    updated because the component output of `wasm32-wasip2` is slightly
    different. A timeout was additionally added because without `-pthread`
    at the link step some tests infinitely ran which made debugging
    difficult.
    alexcrichton committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a1a9344 View commit details
    Browse the repository at this point in the history