Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable docker cache with github actions #463

Closed
wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Collaborator

The container in this repository does not take long to build and the caches look like they're take a nontrivial amount of space in CI. Try to free up more room for LLVM caches which are the main reason to use caching in this repository.

The container in this repository does not take long to build and the
caches look like they're take a nontrivial amount of space in CI. Try to
free up more room for LLVM caches which are the main reason to use
caching in this repository.
Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but wanted to note what it seems to change:

  • the Build and test (Linux) step calls docker-build.sh, which builds everything in Docker
  • the Build x86_64-linux matrix job calls this step and (unscientifically) was around 21 minutes prior to this change
  • this change seems to increase the Build and test (Linux) step to 26 minutes, presumably because we need to re-pull some Docker images (?)

In any case, I don't think this is the longest pole in the tent: the Build x86_64-windows job is taking 40-50 minutes... wonder why that is so much slower?

@alexcrichton
Copy link
Collaborator Author

This should only affect the "Finalize wasi-sdk artifacts" action and shouldn't have any affect on the other jobs. Specifically the "Build and push wasi-sdk docker image" step is affected by this caching. Looking at a previous run it looks like it took 52s and on this PR it took 5m49s. I didn't realize this would lead to such a large discrepancy in performance. My guess is that building the arm64 container image requires a lot to run through QEMU and that probably isn't the fastest thing in the world.

@alexcrichton alexcrichton deleted the no-docker-cache branch July 31, 2024 18:00
@alexcrichton
Copy link
Collaborator Author

Oh, as for windows, looks like while a cache was restored ccache -s reported mostly misses, so for whatever reason the restored cache wasn't valid (not sure why myself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants