Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 19 #474

Closed
wants to merge 3 commits into from
Closed

Conversation

alexcrichton
Copy link
Collaborator

This commit updates the LLVM submodule to the release/19.x branch from the previous 18.1.2 version

This commit updates the LLVM submodule to the `release/19.x` branch from
the previous 18.1.2 version
@alexcrichton
Copy link
Collaborator Author

This currently updates to llvmorg-19.1.0-rc1 as LLVM 19 isn't actually officially released yet. I get errors building locally that I don't know much about, so going to get some links on CI here to share with others.

@TerrorJack
Copy link
Contributor

TerrorJack commented Aug 12, 2024

I guess you're seeing something like wasm-ld: error: build/wasm32-wasip2/libwasi-emulated-mman.so.a(mman.pic.o): undefined symbol: errno? It's due to 22b7b84860d39da71964c9b329937f2ee1d875ba that also ended up in the 19.x branch that I discovered today.

@sbc100
Copy link
Member

sbc100 commented Aug 12, 2024

I guess you're seeing something like wasm-ld: error: build/wasm32-wasip2/libwasi-emulated-mman.so.a(mman.pic.o): undefined symbol: errno? It's due to 22b7b84860d39da71964c9b329937f2ee1d875ba that also ended up in the 19.x branch that I discovered today.

Does this look like an linker bug, or is that symbol actually missing?

@yamt
Copy link
Contributor

yamt commented Aug 13, 2024

I guess you're seeing something like wasm-ld: error: build/wasm32-wasip2/libwasi-emulated-mman.so.a(mman.pic.o): undefined symbol: errno? It's due to 22b7b84860d39da71964c9b329937f2ee1d875ba that also ended up in the 19.x branch that I discovered today.

Does this look like an linker bug, or is that symbol actually missing?

cf. WebAssembly/wasi-libc#526

most of symbols seem to be the latter. (wasi-libc bug)

but some of them seems like a linker bug because they are expected to be provided by linker.
ie. __heap_base, __heap_end, __c_longjmp.

@TerrorJack
Copy link
Contributor

WebAssembly/wasi-libc#526 is a much better solution than simply adding -Wl,--unresolved-symbols=import-dynamic in wasi-libc build logic, we should land that one first IMO.

alexcrichton added a commit to alexcrichton/wasi-sdk that referenced this pull request Aug 14, 2024
These aren't needed anyway and fix a build issue discovered in WebAssembly#474.
Additionally a typo was fixed here too.
@alexcrichton
Copy link
Collaborator Author

I moved the relevant bits here to #476 and the removal of -DLLVM_ENABLE_TERMINFO=OFF can happen when LLVM is actually updated.

@alexcrichton alexcrichton deleted the llvm19 branch August 14, 2024 14:44
yamt pushed a commit to yamt/wasi-sdk that referenced this pull request Aug 23, 2024
These aren't needed anyway and fix a build issue discovered in WebAssembly#474.
Additionally a typo was fixed here too.
abrown pushed a commit that referenced this pull request Aug 27, 2024
These aren't needed anyway and fix a build issue discovered in #474.
Additionally a typo was fixed here too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants