Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM 19 + setjmp/longjmp doc #480

Merged
merged 6 commits into from
Sep 24, 2024
Merged

LLVM 19 + setjmp/longjmp doc #480

merged 6 commits into from
Sep 24, 2024

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Aug 23, 2024

this is a draft because:


```shell
clang -Os -flto=full -mllvm -wasm-enable-sjlj -Wl,-mllvm,-wasm-enable-sjlj -o your_app.wasm your_app.c -lsetjmp
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently broken. see WebAssembly/wasi-libc#529

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@yamt
Copy link
Contributor Author

yamt commented Aug 23, 2024

windows failure needs an investigation.
maybe a regression in WebAssembly/wasi-libc#526 ?

2024-08-23T07:45:02.3027061Z C:/wasi-sdk/install/bin/clang.exe -fdebug-prefix-map=D:/a/wasi-sdk/wasi-sdk=wasisdk://v24.8g43219b2e8914 -resource-dir C:/wasi-sdk/sysroot/install/wasi-resource-dir -O2 -g -DNDEBUG --target=wasm32-wasi -fno-trapping-math -Wall -Wextra -Werror -Wno-null-pointer-arithmetic -Wno-unused-parameter -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-ignored-attributes -Wno-missing-braces -Wno-ignored-pragmas -Wno-unused-but-set-variable -Wno-unknown-warning-option -mthread-model single -isystem "C:/wasi-sdk/sysroot/install/share/wasi-sysroot/include/wasm32-wasi" -nodefaultlibs -shared --sysroot=C:/wasi-sdk/sysroot/install/share/wasi-sysroot \
2024-08-23T07:45:02.3098443Z -o C:/wasi-sdk/sysroot/install/share/wasi-sysroot/lib/wasm32-wasi/libc.so -Wl,--whole-archive build/wasm32-wasi/libc.so.a -Wl,--no-whole-archive C:/wasi-sdk/sysroot/install/wasi-resource-dir\lib\wasi\libclang_rt.builtins-wasm32.a \
2024-08-23T07:45:02.3150232Z -Wl,--allow-undefined-file=linker-provided-symbols.txt
2024-08-23T07:45:02.3227562Z # Collect symbol information.
2024-08-23T07:45:02.3273237Z # silently dropping the tail.
2024-08-23T07:45:02.3477724Z #
2024-08-23T07:45:02.3511021Z C:/wasi-sdk/install/bin/llvm-ar.exe crs build/wasm32-wasi/libsetjmp.so.a 
2024-08-23T07:45:02.3615937Z clang: error: no such file or directory: 'C:/wasi-sdk/sysroot/install/wasi-resource-dirlibwasilibclang_rt.builtins-wasm32.a'
2024-08-23T07:45:02.4196867Z make: *** [Makefile:624: C:/wasi-sdk/sysroot/install/share/wasi-sysroot/lib/wasm32-wasi/libc.so] Error 1

@yamt yamt changed the title LLVM 19 LLVM 19 + setjmp/longjmp doc Aug 24, 2024
@yamt
Copy link
Contributor Author

yamt commented Aug 26, 2024

windows failure needs an investigation. maybe a regression in WebAssembly/wasi-libc#526 ?

2024-08-23T07:45:02.3027061Z C:/wasi-sdk/install/bin/clang.exe -fdebug-prefix-map=D:/a/wasi-sdk/wasi-sdk=wasisdk://v24.8g43219b2e8914 -resource-dir C:/wasi-sdk/sysroot/install/wasi-resource-dir -O2 -g -DNDEBUG --target=wasm32-wasi -fno-trapping-math -Wall -Wextra -Werror -Wno-null-pointer-arithmetic -Wno-unused-parameter -Wno-sign-compare -Wno-unused-variable -Wno-unused-function -Wno-ignored-attributes -Wno-missing-braces -Wno-ignored-pragmas -Wno-unused-but-set-variable -Wno-unknown-warning-option -mthread-model single -isystem "C:/wasi-sdk/sysroot/install/share/wasi-sysroot/include/wasm32-wasi" -nodefaultlibs -shared --sysroot=C:/wasi-sdk/sysroot/install/share/wasi-sysroot \
2024-08-23T07:45:02.3098443Z -o C:/wasi-sdk/sysroot/install/share/wasi-sysroot/lib/wasm32-wasi/libc.so -Wl,--whole-archive build/wasm32-wasi/libc.so.a -Wl,--no-whole-archive C:/wasi-sdk/sysroot/install/wasi-resource-dir\lib\wasi\libclang_rt.builtins-wasm32.a \
2024-08-23T07:45:02.3150232Z -Wl,--allow-undefined-file=linker-provided-symbols.txt
2024-08-23T07:45:02.3227562Z # Collect symbol information.
2024-08-23T07:45:02.3273237Z # silently dropping the tail.
2024-08-23T07:45:02.3477724Z #
2024-08-23T07:45:02.3511021Z C:/wasi-sdk/install/bin/llvm-ar.exe crs build/wasm32-wasi/libsetjmp.so.a 
2024-08-23T07:45:02.3615937Z clang: error: no such file or directory: 'C:/wasi-sdk/sysroot/install/wasi-resource-dirlibwasilibclang_rt.builtins-wasm32.a'
2024-08-23T07:45:02.4196867Z make: *** [Makefile:624: C:/wasi-sdk/sysroot/install/share/wasi-sysroot/lib/wasm32-wasi/libc.so] Error 1

fixed in WebAssembly/wasi-libc#526

@yamt yamt marked this pull request as ready for review September 18, 2024 06:31
Copy link
Collaborator

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here look good to me and with LLVM 19 being release we likely want to do a release of wasi-sdk in the near future, so I'm going to merge this.

@alexcrichton alexcrichton merged commit 54545d5 into WebAssembly:main Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants