Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation and usage instructions in README.md #488

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

seclerp
Copy link
Contributor

@seclerp seclerp commented Sep 13, 2024

Hi!

I just tried the installation scripts for the GitHub workflow and it seems like the release artifacts layout has been changed a bit, so installation and usage shell scripts need a little update.

@sbc100 sbc100 requested a review from abrown September 17, 2024 17:17
README.md Outdated Show resolved Hide resolved
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the title to mention that this is an update the readme. Something like: "Fix installation and usage instruction in README.md"?

@seclerp seclerp changed the title Add missing architecture URL part to the installation script Fix installation and usage instructions in README.md Sep 17, 2024
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

@seclerp seclerp requested a review from yamt September 18, 2024 15:23
@abrown abrown enabled auto-merge (squash) September 18, 2024 15:49
@abrown abrown merged commit adbbf2c into WebAssembly:main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants