Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Wasm 1.0 banner #383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bvisness
Copy link

@bvisness bvisness commented Jun 5, 2024

Per some CG meeting discussion :)

(This PR is a bit cheeky, and it may be better to instead update the contents of the banner to reflect what is currently shipped.)

@dschuff
Copy link
Member

dschuff commented Jun 10, 2024

Generally LGTM, but maybe we should separate the dependence updates from the functional change :)

@chicoxyzzy
Copy link
Member

@bvisness would you be open to revert changes in gemfile?

Copy link
Collaborator

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't asked, but this change LGTM.

@bvisness
Copy link
Author

bvisness commented Nov 7, 2024

I'll revert the gemfile stuff, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants