Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch hinting feature #386

Closed
wants to merge 2 commits into from
Closed

Add branch hinting feature #386

wants to merge 2 commits into from

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Jun 14, 2024

No description provided.

@dschuff
Copy link
Member Author

dschuff commented Jun 14, 2024

@yuri91 Do you know what flags are required to enable this feature on various browser implementations?
It would be nice to add support for the proposal to https://github.com/GoogleChromeLabs/wasm-feature-detect but... I guess that will be hard because there's no validation failure that can be detected like we do for the other features. Have you had any thoughts on that?

@yuri91
Copy link

yuri91 commented Jun 17, 2024

Yeah there is no way to test if the feature is implemented. but on the upside it means that people can just always include the hints section in their modules, and the module will run.

about flags:
I am not certain but I believe that JSC has no flags and just always reads the section.
for SpiderMonkey, it's --enable-wasm-branch-hinting, but i am not sure if it's on by default or not

@dschuff
Copy link
Member Author

dschuff commented Jun 17, 2024

I imagine it would not be on by default if there's a flag for it (since the way browsers usually ship features is to put them behind a flag, and then flip the default from off to on... and they don't generally do that until a proposal reaches phase 4).
Maybe @eqrion could confirm about Firefox and @ddegazio about webkit.

@dschuff dschuff closed this Aug 30, 2024
@dschuff dschuff deleted the dschuff-patch-1 branch August 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants