-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraalWasm to "Feature Extensions" page. #396
Conversation
Thanks for adding this! As you're at it, maybe group all pure Wasm engines together, that is, move Node.js and Deno after the browsers, and then come all the Wasm engines. I'll be working on the site soon™, so for now I think it's fine if the table requires scrolling and maybe doesn't look perfect. |
Sure, happy to do that. It's just that GraalWasm can not just be used as pure Wasm engine, but also in conjunction with GraalJS (our JavaScript runtime) and even in our GraalVM Node.js runtime. So I'd argue it's somewhere in between Node.js/Deno and the pure Wasm engines. Should I put it in between? What do you think?
Ok great, thank you! |
SGTM, thanks! |
@tomayac I have re-ordered the engines as discussed (see updated screenshot in the PR description). I've also changed the link for GraalWasm, so that this can be merged now. I can open a follow-up PR to adjust the link to the new landing page for GraalWasm when it's ready. |
Thank you very much! |
Thanks for accepting the PR. :) |
This is following up on #396. The new GraalWasm landing page is now available at https://www.graalvm.org/webassembly/.
(Disclaimer: I'm on the GraalVM team that maintains GraalWasm).
This PR adds GraalWasm to the Feature Extensions page. GraalWasm is an open-source WebAssembly runtime written in Java using our Truffle framework. We introduced it in 2019 and plan to declare it as stable in the upcoming 24.1.0 release on September 17, 2024.
Note that https://graalvm.org/webassembly will become available in the next couple of days, we are still working on it.
I thought I open this PR now because it seems that the Feature Extensions page may need a little tweaking. With the additional GraalWasm entry, the table starts to become wider than the content box, causing an awkward horizontal scrollbar (see below). I'm happy to incorporate any fixes or improvements for this.