Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM wip #154

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WASM wip #154

wants to merge 1 commit into from

Conversation

jasoncolburne
Copy link
Collaborator

@jasoncolburne jasoncolburne commented Nov 12, 2023

Rationale

We want WASM to work.

Testing

Install dependencies as outlined here

Navigate to wasm/demo/web in your shell and run:

npm install
npm run serve

For Reviewers

  • Verify version bumped in Cargo.toml

js-sys = '0.3'
serde_json = "1.0"

[dev-dependencies]
wasm-bindgen-test = "0.3.38"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be used for headless browser testing

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #154 (55c8780) into main (43a011b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          32       32           
  Lines        3037     3037           
=======================================
  Hits         2897     2897           
  Misses        140      140           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@m00sey
Copy link
Member

m00sey commented Nov 16, 2023

Addresses #108

@daidoji
Copy link
Collaborator

daidoji commented Dec 15, 2023

@jasoncolburne we can probably close this one. My PR built off this branch so it should contain all this and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants