Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: de-couple contact creation from OOBI resolution #882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Oct 17, 2024

This will resolve WebOfTrust/keria#291 and also avoid the lack of clarity raised in WebOfTrust/keria#292. As dicussed on Discord.

kli command added to add the alias using org.replace. I added it to the demo scripts that seemed to need the contact to be in place. Many don't require it, but I hope I didn't miss too many.

@m00sey m00sey self-assigned this Oct 17, 2024
@m00sey m00sey removed their assignment Nov 8, 2024
@m00sey
Copy link
Member

m00sey commented Nov 8, 2024

Removed GLEIF so this PR can make progress - we don't have time to address it now.

We have not upgraded to 1.2 yet so we can address our own concerns when we do.

@iFergal
Copy link
Contributor Author

iFergal commented Nov 8, 2024

Cool thanks! @pfeairheller let me know if the kli command is OK on your side.

I think this change should be OK for the KERIA side @2byrds @lenkan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact attributes disappears after re-resolving OOBI and querying key state
2 participants