Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors to match system color scheme #13378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meel-hd
Copy link
Contributor

@meel-hd meel-hd commented Dec 23, 2024

Proposed changes

When users are unauthenticated by default the theme is set to auto (which was before this fix selects incorrect colors). But when the user is logged in, the theme is set to his preference: light or dark instead of the auto theme.

The fix now selects the configured(dark/light) theme colors to match the sytem(dark/light) theme in auto theme. But only when the user is unauthenticated or he chose to.
Close: #13376

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

But only when user is unauthenticated or he chose to.
Otherwise, the colors are defined to match user preference either dark or light.

Close: WeblateOrg#13376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark color settings aren't applied for unauthenticated users
1 participant