Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduction is always 'mean' #14

Open
tkbadamdorj opened this issue Jan 20, 2022 · 1 comment
Open

reduction is always 'mean' #14

tkbadamdorj opened this issue Jan 20, 2022 · 1 comment

Comments

@tkbadamdorj
Copy link

Setting reduction = 'sum' does not work because of this line:

if self._reduction:
    merged_grad[shared] = torch.stack([g[shared]
                                   for g in pc_grad]).mean(dim=0)

because if reduction is a string, self._reduction is always True

@anzeyimana
Copy link

See the forked version here with the issue corrected:

https://github.com/anzeyimana/Pytorch-PCGrad-GradVac-AMP-GradAccum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants