-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qdt export): initialization of qdt export #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkerloch
force-pushed
the
feat-qdt-profile-export
branch
from
October 2, 2024 08:12
1ffb76e
to
b626113
Compare
Guts
reviewed
Oct 3, 2024
- qgis profiles path - profile list - QGIS3.ini for profile - metadata from plugin in profile - metadata for plugin from QGIS
- copy all profile content - remove cache folders - remove python plugin folders - create profile.json file for QDT from profile plugins
- use QgsUserProfileManager to get available profiles - connect to profilesChanged for model update
… profile combobox - convert QListWidget to QListView - add function in ProfileManagerDialog to get current selected profile in list
- closes Profile Manager does not respect --profiles-path start up option WhereGroup#5
for more information, see https://pre-commit.ci
jmkerloch
force-pushed
the
feat-qdt-profile-export
branch
from
October 3, 2024 16:11
9bf37ac
to
016484e
Compare
Guts
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀!
We have a plugin ready for a new release!
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a new panel in profile-manager to export profile as QDT profile .json file (https://guts.github.io/qgis-deployment-cli/reference/qdt_profile.html#model-definition) with a copy of the profile files used by QDT.
Refactoring
For better maintability of the project we moved and updated some functions from the main plugin entrypoint (
profile_manager/profile_manager.py
) to a new file (profile_manager/profiles/utils.py
)New functions are defined to get information about the profiles:
qgis_profiles_path
: remove use of platform specific code to get information from pyQgis :iface.userProfileManager().rootLocation()
: this closes issue Profile Manager does not respect --profiles-path start up option #5get_profile_qgis_ini_path
GUI
Since we needed a way to display the available profiles, we created a
QStandardItemModel
:ProfileListModel
.This model is using
QgsUserProfileManager
to get all available profile and also be notified any time a new profile is created.This model is now used for all profile selection combobox / listview.
We also are displaying profile icon.
QDT Export
A new panel is added in main GUI.
You can select profile to export and define the export directory and some informations about the QDT Profile.
If a QDT profile.json file is already available we are reading informations for QDT profile creation in file.
When creating a QDT Profile export directory we:
Missing
folder_name
value in QDT profile.json (need to discuss with @Guts)