Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: remove grcov action #28

Open
Segelzwerg opened this issue Jun 10, 2022 · 5 comments · May be fixed by #74
Open

CI: remove grcov action #28

Segelzwerg opened this issue Jun 10, 2022 · 5 comments · May be fixed by #74
Assignees
@Segelzwerg
Labels
ci/cd Continuous integration & deployment

Comments

@Segelzwerg
Copy link
Contributor

This action seems to be no longer maintained use CLI commands instead.
@Segelzwerg Segelzwerg added the ci/cd Continuous integration & deployment label Jun 10, 2022
@iTitus
Copy link
Contributor

iTitus commented Jun 10, 2022

Where did you get that info from?

@Segelzwerg
Copy link
Contributor Author

Where did you get that info from?

https://github.com/actions-rs/grcov

The last release is from 2020 and the last update in main from 2021

@iTitus
Copy link
Contributor

iTitus commented Jun 10, 2022

grcov action != grcov:
The action internally installs the newest release of grcov, so it doesnt need to be alive

@Segelzwerg
Copy link
Contributor Author

grcov action != grcov:
The action internally installs the newest release of grcov, so it doesnt need to be alive

I know, but the action brings some inconvenience and I want to use grcov manually

@iTitus
Copy link
Contributor

iTitus commented Jun 12, 2022

maybe disable coverage entirely as it seems to be broken

@Segelzwerg Segelzwerg linked a pull request Aug 23, 2022 that will close this issue
FIX: coverage #74
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Segelzwerg Segelzwerg

Labels
ci/cd Continuous integration & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: coverage Whist-Team/Whist-Browser
2 participants
@iTitus @Segelzwerg