Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: card dictionary #332

Merged
merged 6 commits into from
Jul 25, 2023
Merged

FIX: card dictionary #332

merged 6 commits into from
Jul 25, 2023

Conversation

Segelzwerg
Copy link
Contributor

Due to the override of methods Suit and Rank were not converted to strings.

Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg requested a review from iTitus July 22, 2023 11:16
@Segelzwerg Segelzwerg self-assigned this Jul 22, 2023
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 22, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@Segelzwerg Segelzwerg added the bug Something isn't working label Jul 22, 2023
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #332 (f97f915) into main (c028e6c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   97.13%   97.15%   +0.01%     
==========================================
  Files          29       29              
  Lines         804      809       +5     
==========================================
+ Hits          781      786       +5     
  Misses         23       23              
Impacted Files Coverage Δ
whist_core/cards/card.py 97.72% <100.00%> (+0.13%) ⬆️

Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@iTitus iTitus merged commit 4cdb75e into main Jul 25, 2023
9 checks passed
@iTitus iTitus deleted the fix/card_dict_conversion branch July 25, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants