Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when using Regex #2

Open
Jinx740 opened this issue Jul 10, 2024 · 8 comments
Open

Issue when using Regex #2

Jinx740 opened this issue Jul 10, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Jinx740
Copy link

Jinx740 commented Jul 10, 2024

If you accidently mess up your regex when submitting username format, there is no way to delete and restart or there isn't a way to go back in and edit the regex code.

@whitigol
Copy link
Contributor

After creating the profile, you can click into the profile, and at the bottom left, click "Profile Settings". You should be able to edit the name regex there.

@whitigol whitigol self-assigned this Jul 17, 2024
@Jinx740
Copy link
Author

Jinx740 commented Jul 17, 2024

Negative, when i click on the community i get something went wrong message and cant do anyrthing else.
Capture

@whitigol
Copy link
Contributor

Could you try that expression without the leading or trailing /? I think that may be causing some issues.

@Jinx740
Copy link
Author

Jinx740 commented Jul 18, 2024

I cant change anything, i click on the community and that page comes up. Cant do anything but close it.

@whitigol
Copy link
Contributor

In that case, you may have to recreate the profile using the regex pattern without / leading or trailing. If you use the same profile ID as you did with the initial one, it should overwrite the existing profile.

I'll be sure to release a fix for this in one of the coming updates.

@whitigol whitigol moved this to Backlog in wLauncher Project Board Jul 18, 2024
@whitigol whitigol added the bug Something isn't working label Jul 18, 2024
@whitigol whitigol moved this from Backlog to Ready in wLauncher Project Board Jul 18, 2024
@whitigol whitigol moved this from Ready to In progress in wLauncher Project Board Jul 24, 2024
@whitigol whitigol moved this from In progress to In review in wLauncher Project Board Jul 24, 2024
@whitigol
Copy link
Contributor

Upon review, the regex pattern in the error message is invalid. It seems that in the second character class ([1,3}), you have a closing curly brace } instead of a closing square bracket ]. Could you please update that and see if it resolves the issue?

Additionally, I have implemented a fix that validates the provided pattern to ensure the application won't crash if the regex is invalid. This fix is currently in testing.

@Jinx740
Copy link
Author

Jinx740 commented Jul 24, 2024 via email

@FearlessNite345
Copy link

Unable to save the Regex after a profile is already created it acts like it saved cause it follows the new Regex for that time until you either click out of the profile or you restart the launcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In review
Development

No branches or pull requests

3 participants