Skip to content

Commit

Permalink
added Optional to necessary params (#34)
Browse files Browse the repository at this point in the history
* added Optional to necessary params

* rev up

---------

Co-authored-by: Josh Lloyd <jlloyd@ip-10-0-0-7.ec2.internal>
  • Loading branch information
jlloyd-widen and Josh Lloyd authored May 25, 2023
1 parent 3ae34bc commit 69643af
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "tap-rest-api-msdk"
version = "1.1.2"
version = "1.2.0"
description = "`tap-rest-api-msdk` is a Singer tap for REST APIs, built with the Meltano SDK for Singer Taps."
authors = ["Josh Lloyd", "Fred Reimer"]
keywords = [
Expand Down
16 changes: 8 additions & 8 deletions tap_rest_api_msdk/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@ def __init__(
name: str,
records_path: str,
path: str,
params: dict = None,
headers: dict = None,
primary_keys: list = None,
replication_key: str = None,
except_keys: list = None,
next_page_token_path: str = None,
schema: dict = None,
params: Optional[dict] = None,
headers: Optional[dict] = None,
primary_keys: Optional[list] = None,
replication_key: Optional[str] = None,
except_keys: Optional[list] = None,
next_page_token_path: Optional[str] = None,
schema: Optional[dict] = None,
pagination_request_style: str = "default",
pagination_response_style: str = "default",
pagination_page_size: int = None,
pagination_page_size: Optional[int] = None,
) -> None:
"""Class initialization.
Expand Down
4 changes: 2 additions & 2 deletions tap_rest_api_msdk/utils.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
"""Basic utility functions."""

import json
from typing import Any
from typing import Any, Optional


def flatten_json(obj: dict, except_keys: list = None) -> dict:
def flatten_json(obj: dict, except_keys: Optional[list] = None) -> dict:
"""Flattens a json object by appending the patch as a key in the returned object.
Automatically converts arrays and any provided keys into json strings to prevent
Expand Down

0 comments on commit 69643af

Please sign in to comment.